ftp/imap/pop3/smtp: Fixed compilation warning when /Wall enabled

warning C4706: assignment within conditional expression

diff --git a/lib/curl_sasl.c b/lib/curl_sasl.c
index aac2bcd29497221e0cf4a24c6ad1c93ebfc54900..945d7523256753ed118a17b724421285422ae02e 100644 (file)
--- a/lib/curl_sasl.c
+++ b/lib/curl_sasl.c
@@ -1300,11 +1300,13 @@ CURLcode Curl_sasl_parse_url_auth_option(struct SASL *sasl,
 
   if(strnequal(value, "*", len))
     sasl->prefmech = SASL_AUTH_DEFAULT;
-  else if((mechbit = Curl_sasl_decode_mech(value, len, &mechlen)) &&
-          mechlen == len)
-    sasl->prefmech |= mechbit;
-  else
-    result = CURLE_URL_MALFORMAT;
+  else {
+    mechbit = Curl_sasl_decode_mech(value, len, &mechlen);
+    if(mechbit && mechlen == len)
+      sasl->prefmech |= mechbit;
+    else
+      result = CURLE_URL_MALFORMAT;
+  }
 
   return result;
 }
@@ -1600,7 +1602,8 @@ CURLcode Curl_sasl_continue(struct SASL *sasl, struct connectdata *conn,
     newstate = SASL_DIGESTMD5_RESP;
     break;
   case SASL_DIGESTMD5_RESP:
-    if(!(resp = strdup("")))
+    resp = strdup("");
+    if(!resp)
       result = CURLE_OUT_OF_MEMORY;
     break;
 #endif

diff --git a/lib/ftp.c b/lib/ftp.c
index 40c51ead5579bff4cb71791021c6cd38ab9f24cd..9b728cc98ab08f63a1a4f48e6fbbb1dfc0c4614c 100644 (file)
--- a/lib/ftp.c
+++ b/lib/ftp.c
@@ -155,8 +155,9 @@ static CURLcode ftp_dophase_done(struct connectdata *conn,
                                  bool connected);
 
 /* easy-to-use macro: */
-#define PPSENDF(x,y,z)  if((result = Curl_pp_sendf(x,y,z)))     \
-                              return result
+#define PPSENDF(x,y,z)  result = Curl_pp_sendf(x,y,z); \
+                        if(result)                     \
+                          return result
 
 
 /*

diff --git a/lib/imap.c b/lib/imap.c
index a3d2cad22411e3c4fa7e61e921c5d9ac9e2b8ca9..ff25e54e099e3091e820ea2745be62836934d3c1 100644 (file)
--- a/lib/imap.c
+++ b/lib/imap.c
@@ -910,8 +910,8 @@ static CURLcode imap_state_capability_resp(struct connectdata *conn,
         wordlen -= 5;
 
         /* Test the word for a matching authentication mechanism */
-        if((mechbit = Curl_sasl_decode_mech(line, wordlen, &llen)) &&
-           llen == wordlen)
+        mechbit = Curl_sasl_decode_mech(line, wordlen, &llen);
+        if(mechbit && llen == wordlen)
           imapc->sasl.authmechs |= mechbit;
       }
 

diff --git a/lib/pop3.c b/lib/pop3.c
index cb53b7445b2163ae9ddbb20aff9013662352183d..823761d2ee7f3edb613d9d306dd6af5ea4a4d043 100644 (file)
--- a/lib/pop3.c
+++ b/lib/pop3.c
@@ -753,8 +753,8 @@ static CURLcode pop3_state_capa_resp(struct connectdata *conn, int pop3code,
           wordlen++;
 
         /* Test the word for a matching authentication mechanism */
-        if((mechbit = Curl_sasl_decode_mech(line, wordlen, &llen)) &&
-           llen == wordlen)
+        mechbit = Curl_sasl_decode_mech(line, wordlen, &llen);
+        if(mechbit && llen == wordlen)
           pop3c->sasl.authmechs |= mechbit;
 
         line += wordlen;

diff --git a/lib/smtp.c b/lib/smtp.c
index 2a87c6eae637fec559ad00a40279fe5dbcd4d50b..83e51bf8059d639acc3fb6d26b131c69ac99445e 100644 (file)
--- a/lib/smtp.c
+++ b/lib/smtp.c
@@ -770,8 +770,8 @@ static CURLcode smtp_state_ehlo_resp(struct connectdata *conn, int smtpcode,
           wordlen++;
 
         /* Test the word for a matching authentication mechanism */
-        if((mechbit = Curl_sasl_decode_mech(line, wordlen, &llen)) &&
-           llen == wordlen)
+        mechbit = Curl_sasl_decode_mech(line, wordlen, &llen);
+        if(mechbit && llen == wordlen)
           smtpc->sasl.authmechs |= mechbit;
 
         line += wordlen;