Fix a bug where errors that happen during early request parsing (like 400

HTTP_BAD_REQUEST) don't send any error message content to the browser.
The core_filter wasn't present this early in request parsing, so the output
went into the bit bucket via r[v]puts->ap_pass_brigade.

The chunking filter takes care of itself nicely, because it is added in
ap_send_http_header if it's needed.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86253 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/modules/http/http_core.c b/modules/http/http_core.c
index 499bdc88445a497f7e9b9616dd8f0db7c940fad3..d676b02924c49ff8e8f38d7a8a39eeda7f1a8e26 100644 (file)
--- a/modules/http/http_core.c
+++ b/modules/http/http_core.c
@@ -3146,8 +3146,6 @@ static void core_register_filter(request_rec *r)
         char *foobar = items[i];
         ap_add_filter(foobar, NULL, r);
     }
-
-    ap_add_filter("CORE", NULL, r);
 }
 
 static void register_hooks(void)

diff --git a/modules/http/http_protocol.c b/modules/http/http_protocol.c
index cc208887e3b8f7e7037feadd2f98532d916522f8..5d81855733c70dbe3b0115831fa56644278c33a4 100644 (file)
--- a/modules/http/http_protocol.c
+++ b/modules/http/http_protocol.c
@@ -1200,6 +1200,8 @@ request_rec *ap_read_request(conn_rec *conn)
     r->status          = HTTP_REQUEST_TIME_OUT;  /* Until we get a request */
     r->the_request     = NULL;
 
+    ap_add_filter("CORE", NULL, r);
+
 #ifdef APACHE_XLATE
     r->rrx = apr_pcalloc(p, sizeof(struct ap_rr_xlate));
     ap_set_content_xlate(r, 0, ap_locale_from_ascii);