]> granicus.if.org Git - libvpx/commitdiff
fix vp9_wb_write_bit uninitialized variable
authorJim Bankoski <jimbankoski@google.com>
Thu, 6 Jun 2013 23:48:34 +0000 (16:48 -0700)
committerJim Bankoski <jimbankoski@google.com>
Thu, 6 Jun 2013 23:48:34 +0000 (16:48 -0700)
This fixes a valgrind error.

Change-Id: I0e1ef212ba09d65e3d71dd209f0786ae6530d2c8

vp9/encoder/vp9_write_bit_buffer.h

index 18cf4036698252eb81dc35870824f334dce47009..98ad3f608d7fe9854eedb695098f90ffad7b0042 100644 (file)
@@ -26,8 +26,12 @@ static void vp9_wb_write_bit(struct vp9_write_bit_buffer *wb, int bit) {
   const int off = wb->bit_offset;
   const int p = off / CHAR_BIT;
   const int q = CHAR_BIT - 1 - off % CHAR_BIT;
-  wb->bit_buffer[p] &= ~(1 << q);
-  wb->bit_buffer[p] |= bit << q;
+  if (q == CHAR_BIT -1) {
+    wb->bit_buffer[p] = bit << q;
+  } else {
+    wb->bit_buffer[p] &= ~(1 << q);
+    wb->bit_buffer[p] |= bit << q;
+  }
   wb->bit_offset = off + 1;
 }