Sort overload results by viability.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@93215 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/lib/Sema/SemaOverload.cpp b/lib/Sema/SemaOverload.cpp
index 74b548cb962acaa5e03c664dd4c449c48b465d59..a7d4f372d10b6c0e5ed3b012f6d8bc435f9f1a60 100644 (file)
--- a/lib/Sema/SemaOverload.cpp
+++ b/lib/Sema/SemaOverload.cpp
@@ -4422,28 +4422,36 @@ void NoteAmbiguousUserConversions(Sema &S, SourceLocation OpLoc,
   }
 }
 
-struct CompareOverloadCandidates {
-  SourceManager &SM;
-  CompareOverloadCandidates(SourceManager &SM) : SM(SM) {}
+struct CompareOverloadCandidatesForDisplay {
+  Sema &S;
+  CompareOverloadCandidatesForDisplay(Sema &S) : S(S) {}
 
   bool operator()(const OverloadCandidate *L,
                   const OverloadCandidate *R) {
     // Order first by viability.
-    if (L->Viable != R->Viable)
-      return L->Viable;
+    if (L->Viable) {
+      if (!R->Viable) return true;
+
+      // TODO: introduce a tri-valued comparison for overload
+      // candidates.  Would be more worthwhile if we had a sort
+      // that could exploit it.
+      if (S.isBetterOverloadCandidate(*L, *R)) return true;
+      if (S.isBetterOverloadCandidate(*R, *L)) return false;
+    } else if (R->Viable)
+      return false;
 
     // Put declared functions first.
     if (L->Function) {
       if (!R->Function) return true;
-      return SM.isBeforeInTranslationUnit(L->Function->getLocation(),
-                                          R->Function->getLocation());
+      return S.SourceMgr.isBeforeInTranslationUnit(L->Function->getLocation(),
+                                                   R->Function->getLocation());
     } else if (R->Function) return false;
 
     // Then surrogates.
     if (L->IsSurrogate) {
       if (!R->IsSurrogate) return true;
-      return SM.isBeforeInTranslationUnit(L->Surrogate->getLocation(),
-                                          R->Surrogate->getLocation());
+      return S.SourceMgr.isBeforeInTranslationUnit(L->Surrogate->getLocation(),
+                                                   R->Surrogate->getLocation());
     } else if (R->IsSurrogate) return false;
 
     // And builtins just come in a jumble.
@@ -4470,7 +4478,8 @@ Sema::PrintOverloadCandidates(OverloadCandidateSet& CandidateSet,
        Cand != LastCand; ++Cand)
     if (Cand->Viable || OCD == OCD_AllCandidates)
       Cands.push_back(Cand);
-  std::sort(Cands.begin(), Cands.end(), CompareOverloadCandidates(SourceMgr));
+  std::sort(Cands.begin(), Cands.end(),
+            CompareOverloadCandidatesForDisplay(*this));
   
   bool ReportedAmbiguousConversions = false;