Silence warning in non-assert-enabled build

An OID return value was being used only for a (rather pointless) assert.
Silence by removing the variable and the assert.

Per note from Peter Geoghegan

diff --git a/src/backend/catalog/pg_conversion.c b/src/backend/catalog/pg_conversion.c
index 7de738722bc82741623f89822e6e1a846ed4a131..56ab016cc9cf410e07e1f01ff33cb492f3af6c70 100644 (file)
--- a/src/backend/catalog/pg_conversion.c
+++ b/src/backend/catalog/pg_conversion.c
@@ -50,7 +50,6 @@ ConversionCreate(const char *conname, Oid connamespace,
        bool            nulls[Natts_pg_conversion];
        Datum           values[Natts_pg_conversion];
        NameData        cname;
-       Oid                     oid;
        ObjectAddress myself,
                                referenced;
 
@@ -106,8 +105,7 @@ ConversionCreate(const char *conname, Oid connamespace,
        tup = heap_form_tuple(tupDesc, values, nulls);
 
        /* insert a new tuple */
-       oid = simple_heap_insert(rel, tup);
-       Assert(OidIsValid(oid));
+       simple_heap_insert(rel, tup);
 
        /* update the index if any */
        CatalogUpdateIndexes(rel, tup);