Fix memory leak in plperl_hash_from_tuple(), per report from Jean-Max Reymond.
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 3 Jul 2005 21:56:16 +0000 (21:56 +0000)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 3 Jul 2005 21:56:16 +0000 (21:56 +0000)
src/pl/plperl/plperl.c

index 7d0e00effe18c9969b4c4f34b9fd228a5d34b773..eaee0f79722a0c8a8073f6dfd03efad18ab79f6f 100644 (file)
@@ -33,7 +33,7 @@
  *       ENHANCEMENTS, OR MODIFICATIONS.
  *
  * IDENTIFICATION
- *       $PostgreSQL: pgsql/src/pl/plperl/plperl.c,v 1.78 2005/06/22 16:45:51 tgl Exp $
+ *       $PostgreSQL: pgsql/src/pl/plperl/plperl.c,v 1.79 2005/07/03 21:56:16 tgl Exp $
  *
  **********************************************************************/
 
@@ -1327,14 +1327,16 @@ plperl_hash_from_tuple(HeapTuple tuple, TupleDesc tupdesc)
                getTypeOutputInfo(tupdesc->attrs[i]->atttypid,
                                                  &typoutput, &typisvarlena);
 
-               outputstr = DatumGetCString(OidFunctionCall1(typoutput,
-                                                                                                        attr));
+               outputstr = DatumGetCString(OidFunctionCall1(typoutput, attr));
 
                sv = newSVpv(outputstr, 0);
 #if PERL_BCDVERSION >= 0x5006000L
-               if (GetDatabaseEncoding() == PG_UTF8) SvUTF8_on(sv);
+               if (GetDatabaseEncoding() == PG_UTF8)
+                       SvUTF8_on(sv);
 #endif
                hv_store(hv, attname, namelen, sv, 0);
+
+               pfree(outputstr);
        }
 
        return newRV_noinc((SV *) hv);