Move initialising unittest.TestProgram.testRunner into runTests. Issue 6418.

diff --git a/Lib/test/test_unittest.py b/Lib/test/test_unittest.py
index c8fdc15d39edbd92732557a15b011d1b83709c3c..5626542c65eb425af9507e251a200de64e6bfa71 100644 (file)
--- a/Lib/test/test_unittest.py
+++ b/Lib/test/test_unittest.py
@@ -6,6 +6,7 @@ Still need testing:
     TestCase.{assert,fail}* methods (some are tested implicitly)
 """
 
+import sys
 from test import test_support
 import unittest
 from unittest import TestCase
@@ -2285,15 +2286,6 @@ class Test_Assertions(TestCase):
                           self.failIfAlmostEqual, 0, .1+.1j, places=0)
 
 
-class Test_TestProgram(TestCase):
-
-    def testTestProgram_testRunnerArgument(self):
-        program = object.__new__(unittest.TestProgram)
-        program.parseArgs = lambda _: None
-        program.runTests = lambda: None
-        program.__init__(testRunner=None)
-        self.assertEqual(program.testRunner, unittest.TextTestRunner)
-
 
 ######################################################################
 ## Main
@@ -2302,7 +2294,7 @@ class Test_TestProgram(TestCase):
 def test_main():
     test_support.run_unittest(Test_TestCase, Test_TestLoader,
         Test_TestSuite, Test_TestResult, Test_FunctionTestCase,
-        Test_Assertions, Test_TestProgram)
+        Test_Assertions)
 
 if __name__ == "__main__":
     test_main()

diff --git a/Lib/unittest.py b/Lib/unittest.py
index 2ad5de781b994611da61fc47a2d0370b507ad978..74f15d66344d76eba67103c8ca6c019f36258494 100644 (file)
--- a/Lib/unittest.py
+++ b/Lib/unittest.py
@@ -800,8 +800,6 @@ Examples:
     def __init__(self, module='__main__', defaultTest=None,
                  argv=None, testRunner=None,
                  testLoader=defaultTestLoader):
-        if testRunner is None:
-            testRunner = TextTestRunner
         if type(module) == type(''):
             self.module = __import__(module)
             for part in module.split('.')[1:]:
@@ -851,6 +849,9 @@ Examples:
                                                        self.module)
 
     def runTests(self):
+        if self.testRunner is None:
+            self.testRunner = TextTestRunner
+
         if isinstance(self.testRunner, (type, types.ClassType)):
             try:
                 testRunner = self.testRunner(verbosity=self.verbosity)