]> granicus.if.org Git - php/commitdiff
Fixed possible resource leak
authorDmitry Stogov <dmitry@zend.com>
Fri, 15 Feb 2013 13:46:38 +0000 (17:46 +0400)
committerDmitry Stogov <dmitry@zend.com>
Fri, 15 Feb 2013 13:46:38 +0000 (17:46 +0400)
shared_alloc_win32.c

index 4abf23de8f0f408745fffde1e71b3e9b4dbbc2f3..32b7c3a845e5bdd874076400c5ff2331a4d333f2 100644 (file)
@@ -138,6 +138,7 @@ static int zend_shared_alloc_reattach(size_t requested_size, char **error_in)
                err = GetLastError();
                zend_win_error_message(ACCEL_LOG_FATAL, "Unable to read base address", err);
                *error_in="read mapping base";
+               fclose(fp);
                return ALLOC_FAILURE;
        }
        fclose(fp);
@@ -280,6 +281,7 @@ static int create_segments(size_t requested_size, zend_shared_segment ***shared_
                if(!fp) {
                        zend_win_error_message(ACCEL_LOG_WARNING, mmap_base_file, err);
                        zend_win_error_message(ACCEL_LOG_FATAL, "Unable to write base address", err);
+                       return ALLOC_FAILURE;
                }
                fprintf(fp, "%p\n", mapping_base);
                fclose(fp);