Remove warning about potentially unset variable in tests

Also make test function external_entity_public() more robust
against misuse.

diff --git a/expat/tests/runtests.c b/expat/tests/runtests.c
index 81b2734f59d5d6f3fc960be5664e8346475915ce..79fbe522b82cc44688714a4cb543b66eb9be8634 100644 (file)
--- a/expat/tests/runtests.c
+++ b/expat/tests/runtests.c
@@ -5889,7 +5889,7 @@ external_entity_public(XML_Parser parser,
 {
     const char *text1 = (const char *)XML_GetUserData(parser);
     const char *text2 = "<!ATTLIST doc a CDATA 'value'>";
-    const char *text;
+    const char *text = NULL;
     XML_Parser ext_parser;
     int parse_res;
 
@@ -5902,6 +5902,8 @@ external_entity_public(XML_Parser parser,
     else if (publicId != NULL && !strcmp(publicId, "foo")) {
         text = text2;
     }
+    else
+        fail("Unexpected parameters to external entity parser");
     parse_res = _XML_Parse_SINGLE_BYTES(ext_parser, text, strlen(text),
                                    XML_TRUE);
     XML_ParserFree(ext_parser);