]> granicus.if.org Git - sysstat/commitdiff
sar.c: Fix gcc warning about possible variables overlap
authorSebastien GODARD <sysstat@users.noreply.github.com>
Fri, 20 Jul 2018 15:20:36 +0000 (17:20 +0200)
committerSebastien GODARD <sysstat@users.noreply.github.com>
Fri, 20 Jul 2018 15:20:36 +0000 (17:20 +0200)
Fix gcc warning:
sar.c: In function ‘write_stats_avg’:
sar.c:372:2: warning: ‘strcpy’ accessing 1 byte at offsets [0, 64] and [0, 128] may overlap 1 byte at offset 0 [-Wrestrict]
  strcpy(timestamp[!curr], timestamp[curr]);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
sar.c

diff --git a/sar.c b/sar.c
index f2e43062e2027cf4370eb1f2947bb60eb3755182..b387887e5d10f3bc0b5737d185496f234448b2da 100644 (file)
--- a/sar.c
+++ b/sar.c
@@ -369,7 +369,7 @@ void write_stats_avg(int curr, int read_from_file, unsigned int act_id)
 
        strncpy(timestamp[curr], _("Average:"), TIMESTAMP_LEN);
        timestamp[curr][TIMESTAMP_LEN - 1] = '\0';
-       strcpy(timestamp[!curr], timestamp[curr]);
+       memcpy(timestamp[!curr], timestamp[curr], TIMESTAMP_LEN);
 
        /* Test stdout */
        TEST_STDOUT(STDOUT_FILENO);