]> granicus.if.org Git - python/commitdiff
_tkinter: Fix refleak in getint() (#2153)
authorVictor Stinner <victor.stinner@gmail.com>
Tue, 13 Jun 2017 09:12:01 +0000 (11:12 +0200)
committerGitHub <noreply@github.com>
Tue, 13 Jun 2017 09:12:01 +0000 (11:12 +0200)
PyNumber_Int() creates a new reference: need to decrement result
reference counter.

Modules/_tkinter.c

index 46cc64d62e250bed4baae83ab6b1f6eba3ae7348..6053e4bde44473fc0ad296944fbfe23999a90c42 100644 (file)
@@ -2131,8 +2131,12 @@ Tkapp_GetInt(PyObject *self, PyObject *args)
     result = fromWideIntObj(self, value);
 #endif
     Tcl_DecrRefCount(value);
-    if (result != NULL)
-        return PyNumber_Int(result);
+    if (result != NULL) {
+        PyObject *resint = PyNumber_Int(result);
+        Py_DECREF(result);
+        return resint;
+    }
+
     if (PyErr_Occurred())
         return NULL;
 #else