]> granicus.if.org Git - python/commitdiff
Call super in Generic.__init_subclass__ (GH-6356)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Wed, 4 Apr 2018 16:51:34 +0000 (09:51 -0700)
committerGitHub <noreply@github.com>
Wed, 4 Apr 2018 16:51:34 +0000 (09:51 -0700)
(cherry picked from commit ee566fe526f3d069aa313578ee81ca6cbc25ff52)

Co-authored-by: Ivan Levkivskyi <levkivskyi@gmail.com>
Lib/test/test_typing.py
Lib/typing.py

index 09e39fec45e42850f4fbdbb5b3d23acebb0d4b59..b12e5ea2fb80f1fa0d9aa66bb8cf60099b5c3d61 100644 (file)
@@ -1232,6 +1232,25 @@ class GenericTests(BaseTestCase):
         class C(List[int], B): ...
         self.assertEqual(C.__mro__, (C, list, B, Generic, object))
 
+    def test_init_subclass_super_called(self):
+        class FinalException(Exception):
+            pass
+
+        class Final:
+            def __init_subclass__(cls, **kwargs) -> None:
+                for base in cls.__bases__:
+                    if base is not Final and issubclass(base, Final):
+                        raise FinalException(base)
+                super().__init_subclass__(**kwargs)
+        class Test(Generic[T], Final):
+            pass
+        with self.assertRaises(FinalException):
+            class Subclass(Test):
+                pass
+        with self.assertRaises(FinalException):
+            class Subclass(Test[int]):
+                pass
+
     def test_nested(self):
 
         G = Generic
index 510574c413e300067fd25181f3ccce07dfdca2d2..3ac3b93822622b49cdff143a686d0d95f1ddd3c9 100644 (file)
@@ -850,6 +850,7 @@ class Generic:
         return _GenericAlias(cls, params)
 
     def __init_subclass__(cls, *args, **kwargs):
+        super().__init_subclass__(*args, **kwargs)
         tvars = []
         if '__orig_bases__' in cls.__dict__:
             error = Generic in cls.__orig_bases__