]> granicus.if.org Git - taglib/commitdiff
Add const to an unchanged data member.
authorTsuda Kageyu <tsuda.kageyu@gmail.com>
Mon, 30 Nov 2015 07:21:58 +0000 (16:21 +0900)
committerTsuda Kageyu <tsuda.kageyu@gmail.com>
Mon, 30 Nov 2015 07:21:58 +0000 (16:21 +0900)
taglib/riff/rifffile.cpp

index 7d427a46594d8a34edc7faf2c2b94c941ee79c20..9aaf76ef805e180f08a28db1e3870a8f80882bde 100644 (file)
@@ -44,13 +44,11 @@ struct Chunk
 class RIFF::File::FilePrivate
 {
 public:
-  FilePrivate() :
-    endianness(BigEndian),
-    size(0)
-  {
+  FilePrivate(Endianness endianness) :
+    endianness(endianness),
+    size(0) {}
 
-  }
-  Endianness endianness;
+  const Endianness endianness;
   ByteVector type;
   TagLib::uint size;
   ByteVector format;
@@ -71,20 +69,18 @@ RIFF::File::~File()
 // protected members
 ////////////////////////////////////////////////////////////////////////////////
 
-RIFF::File::File(FileName file, Endianness endianness) : TagLib::File(file)
+RIFF::File::File(FileName file, Endianness endianness) :
+  TagLib::File(file),
+  d(new FilePrivate(endianness))
 {
-  d = new FilePrivate;
-  d->endianness = endianness;
-
   if(isOpen())
     read();
 }
 
-RIFF::File::File(IOStream *stream, Endianness endianness) : TagLib::File(stream)
+RIFF::File::File(IOStream *stream, Endianness endianness) :
+  TagLib::File(stream),
+  d(new FilePrivate(endianness))
 {
-  d = new FilePrivate;
-  d->endianness = endianness;
-
   if(isOpen())
     read();
 }