Update arginfo for preg_match_all() to reflect reality.
authorAdam Harvey <aharvey@php.net>
Mon, 12 Nov 2012 12:04:26 +0000 (20:04 +0800)
committerAdam Harvey <aharvey@php.net>
Mon, 12 Nov 2012 12:04:26 +0000 (20:04 +0800)
Back when I implemented FR #53238 during the 5.4 development phase to make the
$matches parameter optional in preg_match_all(), it turns out I forgot to
update the arginfo to note that only 2 parameters are now required by
preg_match_all(). The function itself works fine, but reflection was reporting
the wrong number of required parameters.

ext/pcre/php_pcre.c

index 2f892c8e9402adfa1ca0f3339165bc1d36584df9..b18c9edc7f11efb9e938a0354cca72b627b4d4d6 100644 (file)
@@ -1866,7 +1866,7 @@ ZEND_BEGIN_ARG_INFO_EX(arginfo_preg_match, 0, 0, 2)
     ZEND_ARG_INFO(0, offset)
 ZEND_END_ARG_INFO()
 
-ZEND_BEGIN_ARG_INFO_EX(arginfo_preg_match_all, 0, 0, 3)
+ZEND_BEGIN_ARG_INFO_EX(arginfo_preg_match_all, 0, 0, 2)
     ZEND_ARG_INFO(0, pattern)
     ZEND_ARG_INFO(0, subject)
     ZEND_ARG_INFO(1, subpatterns) /* array */