]> granicus.if.org Git - apache/commitdiff
Be a better example.
authorBen Laurie <ben@apache.org>
Sun, 10 Mar 2002 20:49:29 +0000 (20:49 +0000)
committerBen Laurie <ben@apache.org>
Sun, 10 Mar 2002 20:49:29 +0000 (20:49 +0000)
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93832 13f79535-47bb-0310-9956-ffa450edef68

modules/experimental/mod_case_filter.c

index ae0209d8325d6805c049ddf67487dd2f2147d7f0..c19fa928a928f69dbebe0a2af8c0ba7eed0b8a52 100644 (file)
@@ -58,21 +58,18 @@ static apr_status_t CaseFilterOutFilter(ap_filter_t *f,
             /* XXX: why can't I reuse pbktIn??? */
            apr_bucket *pbktEOS=apr_bucket_eos_create();
            APR_BRIGADE_INSERT_TAIL(pbbOut,pbktEOS);
-           break;
+           continue;
            }
 
        /* read */
        apr_bucket_read(pbktIn,&data,&len,APR_BLOCK_READ);
 
        /* write */
-       buf=apr_palloc(f->r->pool,len);
+       buf=malloc(len);
        for(n=0 ; n < len ; ++n)
            buf[n]=toupper(data[n]);
 
-       /* XXX: should we use a heap bucket instead? Or a transient (in
-        * which case we need a separate brigade for each bucket)?
-         */
-       pbktOut=apr_bucket_pool_create(buf,len,f->r->pool);
+       pbktOut=apr_bucket_heap_create(buf,len,0);
        APR_BRIGADE_INSERT_TAIL(pbbOut,pbktOut);
        }