Fix memory leak in get_editor() if resolve_editor() fails with

an error.  Coverity CID 104107.

diff --git a/plugins/sudoers/visudo.c b/plugins/sudoers/visudo.c
index 320c2e6079646774bdb391cf21d9c90df3561e16..1e594589a42fe1bfda08e9685d47952701d32807 100644 (file)
--- a/plugins/sudoers/visudo.c
+++ b/plugins/sudoers/visudo.c
@@ -331,12 +331,13 @@ get_editor(int *editor_argc, char ***editor_argv)
            if (editor_path != NULL)
                break;
            if (errno != ENOENT)
-               debug_return_str(NULL);
+               goto done;
        }
     }
     if (editor_path == NULL)
        sudo_fatalx(U_("no editor found (editor path = %s)"), def_editor);
 
+done:
     if (whitelist != NULL) {
        while (whitelist_len--)
            free(whitelist[whitelist_len]);