]> granicus.if.org Git - graphviz/commitdiff
remove commented out assertion
authorMatthew Fernandez <matthew.fernandez@gmail.com>
Thu, 8 Jul 2021 03:38:22 +0000 (20:38 -0700)
committerMatthew Fernandez <matthew.fernandez@gmail.com>
Sun, 18 Jul 2021 19:01:10 +0000 (12:01 -0700)
I do not know why the comment says it is surprising the assertion fails. It
seems perfectly normal to me that it would fail, as the correct condition is
against *both* AGINEDGE and AGOUTEDGE as in the following line.

lib/cgraph/grammar.y

index 9dd2a36c88773017cf16fdcff6068e9d080e16f4..8694e1374e4fcd5ef71bbb9e98f5bad04b41159a 100644 (file)
@@ -301,7 +301,6 @@ static void applyattrs(void *obj)
                        }
                }
                else {
-                       /* assert(AGTYPE(obj) == AGEDGE);  surprising this fails */
                        assert((AGTYPE(obj) == AGINEDGE) || (AGTYPE(obj) == AGOUTEDGE));
                        assert(aptr->tag == T_atom);
                        assert(streq(aptr->u.name,Key));