fix #37055 (incorrect reference counting for persistent OCI8 connections)

diff --git a/NEWS b/NEWS
index d05ec59ad0d914375ca3211c300cb64481eee41d..2a3ebe45c0b93b22ab6e0fad5a70a9c220154b18 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -1,6 +1,8 @@
 PHP                                                                        NEWS
 |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
 ?? Apr 2006, PHP 5.1.3
+- Fixed bug #37055 (incorrect reference counting for persistent OCI8 
+  connections). (Tony)
 - Fixed bug #37053 (html_errors with internal classes produces wrong links). 
   (Tony)
 - Fixed bug #37046 (foreach breaks static scope). (Dmitry)

diff --git a/ext/oci8/oci8.c b/ext/oci8/oci8.c
index cfa5a82197a6a7e1a41f6863db638ca7cfd58de3..868c40c4826c7903f77e4507a2b4f1eceb268213 100644 (file)
--- a/ext/oci8/oci8.c
+++ b/ext/oci8/oci8.c
@@ -1056,7 +1056,7 @@ php_oci_connection *php_oci_do_connect_ex(char *username, int username_len, char
                                                        /* okay, the connection is open and the server is still alive */
                                                        connection->used_this_request = 1;
                                                        smart_str_free_ex(&hashed_details, 0);
-                                                       connection->rsrc_id = zend_list_insert(connection, le_pconnection);
+                                                       zend_list_addref(connection->rsrc_id);
                                                        return connection;
                                                }
                                        }