test_hotshot fails on Windows now. Added XXX comment explaining why,

and that I don't know how to fix it.  Fred?

diff --git a/Lib/test/test_hotshot.py b/Lib/test/test_hotshot.py
index ebd2aaa115381d473c597194402104699777e177..db3c914b5bfc51b7dc261f874b903bf76d6aeb5e 100644 (file)
--- a/Lib/test/test_hotshot.py
+++ b/Lib/test/test_hotshot.py
@@ -31,6 +31,10 @@ class UnlinkingLogReader(hotshot.log.LogReader):
         try:
             return hotshot.log.LogReader.next(self)
         except (IndexError, StopIteration):
+            # XXX This fails on Windows because the named file is still
+            # XXX open.  Offhand I couldn't find an appropriate way to close
+            # XXX the file object, or even where the heck it is.  LogReader
+            # XXX in particular doesn't have a close() method.
             os.unlink(self.__logfn)
             raise