Conrad Huang points out that "if (0 < ch < 256)", while legal C,

doesn't mean what the Python programmer thought...

diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c
index b876f342fd76e784a401e6477547062792553545..e4bbcff20cb0548ab700c167d78fa427663c5eaa 100644 (file)
--- a/Objects/unicodeobject.c
+++ b/Objects/unicodeobject.c
@@ -1958,7 +1958,7 @@ int PyUnicode_EncodeDecimal(Py_UNICODE *s,
            *output++ = '0' + decimal;
            continue;
        }
-       if (0 < ch < 256) {
+       if (0 < ch && ch < 256) {
            *output++ = (char) ch;
            continue;
        }