]> granicus.if.org Git - libvpx/commitdiff
Remove unnecessary pointer check
authorJohann <johannkoenig@google.com>
Tue, 3 Feb 2015 20:58:34 +0000 (12:58 -0800)
committerJohann <johannkoenig@google.com>
Tue, 3 Feb 2015 21:03:46 +0000 (13:03 -0800)
The original implementation had the following comment:
// Ignore mv costing if mvsadcost is NULL

However the current implementation does not allow for this.
If x exists then nmvsadcost must not be null.

This removes the only warning from -Wpointer-bool-conversion

https://code.google.com/p/webm/issues/detail?id=894

Change-Id: I1a2cee340d7972d41e1bbbe1ec8dfbe917667085

vp9/encoder/vp9_mcomp.c

index a428f1a2d3228836accb9b811725ccaeba4dcc63..159e0fc0c712b378c2826ba79a2c85fb91a515fb 100644 (file)
@@ -90,13 +90,10 @@ static int mv_err_cost(const MV *mv, const MV *ref,
 
 static int mvsad_err_cost(const MACROBLOCK *x, const MV *mv, const MV *ref,
                           int error_per_bit) {
-  if (x->nmvsadcost) {
-    const MV diff = { mv->row - ref->row,
-                      mv->col - ref->col };
-    return ROUND_POWER_OF_TWO(mv_cost(&diff, x->nmvjointsadcost,
-                                      x->nmvsadcost) * error_per_bit, 8);
-  }
-  return 0;
+  const MV diff = { mv->row - ref->row,
+                    mv->col - ref->col };
+  return ROUND_POWER_OF_TWO(mv_cost(&diff, x->nmvjointsadcost,
+                                    x->nmvsadcost) * error_per_bit, 8);
 }
 
 void vp9_init_dsmotion_compensation(search_site_config *cfg, int stride) {