build: Simplify assertions

Let it leak memory when we assert, so not to confuse static analyzers
as if this is the normal case.

diff --git a/common/test.c b/common/test.c
index c88aff14d126eab35badb7b44693d4f983830627..3827ab0d09fa150b9141fdc4c4b9e03411f0438a 100644 (file)
--- a/common/test.c
+++ b/common/test.c
@@ -482,17 +482,13 @@ p11_test_file_write (const char *base,
        f = fopen (name, "wb");
        if (f == NULL) {
                printf ("# couldn't open file for writing: %s: %s\n", name, strerror (errno));
-               free (path);
                assert_not_reached ();
-               return;
        }
 
        if (fwrite (contents, 1, length, f) != length ||
            fclose (f) != 0) {
                printf ("# couldn't write to file: %s: %s\n", name, strerror (errno));
-               free (path);
                assert_not_reached ();
-               return;
        }
 
        free (path);
@@ -512,9 +508,7 @@ p11_test_file_delete (const char *base,
 
        if (unlink (name) < 0) {
                printf ("# Couldn't delete file: %s\n", name);
-               free (path);
                assert_not_reached ();
-               return;
        }
 
        free (path);