]> granicus.if.org Git - php/commitdiff
MFH: Fixed possible crash on fstat() failure.
authorIlia Alshanetsky <iliaa@php.net>
Mon, 8 Nov 2004 04:55:14 +0000 (04:55 +0000)
committerIlia Alshanetsky <iliaa@php.net>
Mon, 8 Nov 2004 04:55:14 +0000 (04:55 +0000)
ext/fdf/fdf.c

index c627d00b30109ac078879fc7bf46b860799b89ed..32a04ed9188da7036018d6904b30f83a878db208 100644 (file)
@@ -867,7 +867,10 @@ PHP_FUNCTION(fdf_save_string)
                                struct stat stat;
                                char *buf;
 
-                               fstat(fileno(fp), &stat);
+                               if (fstat(fileno(fp), &stat) == -1) {
+                                       RETVAL_FALSE;
+                                       goto err;
+                               }
                                buf = emalloc(stat.st_size +1);
                                fread(buf, stat.st_size, 1, fp);
                                buf[stat.st_size] = '\0';
@@ -885,7 +888,7 @@ PHP_FUNCTION(fdf_save_string)
        if(err != FDFErcOK) {
                FDF_FAILURE(err);
        }
-
+err:
        if(temp_filename) {
                unlink(temp_filename);
                efree(temp_filename);