patch 7.4.1814

Problem:    A channel may be garbage collected while it's still being used by
            a job. (James McCoy)
Solution:   Mark the channel as used if the job is still used.  Do the same
            for channels that are still used.

diff --git a/src/channel.c b/src/channel.c
index d8e55e7b2ea406c49347687d134061ea43b072b6..4b7b6f72c62b8890d75f512cbcbf149f3870b0d7 100644 (file)
--- a/src/channel.c
+++ b/src/channel.c
@@ -3553,28 +3553,15 @@ set_ref_in_channel(int copyID)
 {
     int                abort = FALSE;
     channel_T  *channel;
-    int                part;
+    typval_T   tv;
 
     for (channel = first_channel; channel != NULL; channel = channel->ch_next)
-    {
-       for (part = PART_SOCK; part < PART_IN; ++part)
+       if (channel_still_useful(channel))
        {
-           jsonq_T *head = &channel->ch_part[part].ch_json_head;
-           jsonq_T *item = head->jq_next;
-
-           while (item != NULL)
-           {
-               list_T  *l = item->jq_value->vval.v_list;
-
-               if (l->lv_copyID != copyID)
-               {
-                   l->lv_copyID = copyID;
-                   abort = abort || set_ref_in_list(l, copyID, NULL);
-               }
-               item = item->jq_next;
-           }
+           tv.v_type = VAR_CHANNEL;
+           tv.vval.v_channel = channel;
+           abort = abort || set_ref_in_item(&tv, copyID, NULL, NULL);
        }
-    }
     return abort;
 }
 
@@ -4092,6 +4079,26 @@ job_still_useful(job_T *job)
                       && channel_still_useful(job->jv_channel)));
 }
 
+/*
+ * Mark references in jobs that are still useful.
+ */
+    int
+set_ref_in_job(int copyID)
+{
+    int                abort = FALSE;
+    job_T      *job;
+    typval_T   tv;
+
+    for (job = first_job; job != NULL; job = job->jv_next)
+       if (job_still_useful(job))
+       {
+           tv.v_type = VAR_JOB;
+           tv.vval.v_job = job;
+           abort = abort || set_ref_in_item(&tv, copyID, NULL, NULL);
+       }
+    return abort;
+}
+
     void
 job_unref(job_T *job)
 {

diff --git a/src/eval.c b/src/eval.c
index 2b4f23012c1fcedad75d89d652b3f723fca3624d..fa2f839e3d94418e028a6dac4647c07c73a4ccdc 100644 (file)
--- a/src/eval.c
+++ b/src/eval.c
@@ -7024,6 +7024,7 @@ garbage_collect(int testing)
 
 #ifdef FEAT_JOB_CHANNEL
     abort = abort || set_ref_in_channel(copyID);
+    abort = abort || set_ref_in_job(copyID);
 #endif
 #ifdef FEAT_NETBEANS_INTG
     abort = abort || set_ref_in_nb_channel(copyID);

diff --git a/src/proto/channel.pro b/src/proto/channel.pro
index d14337dc689e5ed5f85041714f710b3590a57b81..5e0bec54b539a939ff3e33f0546c188a2825fa46 100644 (file)
--- a/src/proto/channel.pro
+++ b/src/proto/channel.pro
@@ -49,6 +49,7 @@ void clear_job_options(jobopt_T *opt);
 void free_job_options(jobopt_T *opt);
 int get_job_options(typval_T *tv, jobopt_T *opt, int supported);
 channel_T *get_channel_arg(typval_T *tv, int check_open, int reading, int part);
+int set_ref_in_job(int copyID);
 void job_unref(job_T *job);
 int free_unused_jobs_contents(int copyID, int mask);
 void free_unused_jobs(int copyID, int mask);

diff --git a/src/version.c b/src/version.c
index 5a612d4fa6afb88d04180c97e79908bb1336b594..0d78470579b20d75b8695e9a621b871c6aa79f80 100644 (file)
--- a/src/version.c
+++ b/src/version.c
@@ -753,6 +753,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    1814,
 /**/
     1813,
 /**/