]> granicus.if.org Git - php/commitdiff
Don't suppress notices in rfc1867 tests
authorNikita Popov <nikita.ppv@gmail.com>
Mon, 3 Aug 2020 09:58:28 +0000 (11:58 +0200)
committerNikita Popov <nikita.ppv@gmail.com>
Mon, 3 Aug 2020 09:58:59 +0000 (11:58 +0200)
The references notices in debug builds don't seem to be present
anymore.

13 files changed:
ext/session/tests/rfc1867.phpt
ext/session/tests/rfc1867_cleanup.phpt
ext/session/tests/rfc1867_disabled.phpt
ext/session/tests/rfc1867_disabled_2.phpt
ext/session/tests/rfc1867_inter.phpt
ext/session/tests/rfc1867_no_name.phpt
ext/session/tests/rfc1867_sid_cookie.phpt
ext/session/tests/rfc1867_sid_get.phpt
ext/session/tests/rfc1867_sid_get_2.phpt
ext/session/tests/rfc1867_sid_invalid.phpt
ext/session/tests/rfc1867_sid_only_cookie.phpt
ext/session/tests/rfc1867_sid_only_cookie_2.phpt
ext/session/tests/rfc1867_sid_post.phpt

index 21a70c8a28c55df8d1da8efa7b689150d890abe4..0e189b7aa6545cd6ded77c03e0ae512838eb7b89 100644 (file)
@@ -2,8 +2,6 @@
 session rfc1867
 --INI--
 file_uploads=1
-error_reporting=E_ALL&~E_NOTICE
-comment=debug builds show some additional E_NOTICE errors
 upload_max_filesize=1024
 session.save_path=
 session.name=PHPSESSID
index 63b4e4bc0d3ada5e37ac79dbade8ad348a5d325e..ae5dcbe8dcfa24c66c3ed795f242a5d35731c32f 100644 (file)
@@ -2,8 +2,6 @@
 session rfc1867
 --INI--
 file_uploads=1
-error_reporting=E_ALL&~E_NOTICE
-comment=debug builds show some additional E_NOTICE errors
 upload_max_filesize=1024
 session.save_path=
 session.name=PHPSESSID
@@ -48,7 +46,7 @@ session_start();
 var_dump(session_id());
 var_dump(basename(__FILE__) == $_POST[ini_get("session.upload_progress.name")]);
 var_dump($_FILES);
-var_dump($_SESSION["upload_progress_" . basename(__FILE__)]);
+var_dump(isset($_SESSION["upload_progress_" . basename(__FILE__)]));
 session_destroy();
 ?>
 --EXPECTF--
@@ -82,4 +80,4 @@ array(2) {
     int(1)
   }
 }
-NULL
+bool(false)
index 55707f69073e70ab3c731da2d82a64449356209b..5bedb1de88fc2ffd878c2da02fc69a722f4265cd 100644 (file)
@@ -2,8 +2,6 @@
 session rfc1867 disabled
 --INI--
 file_uploads=1
-error_reporting=E_ALL&~E_NOTICE
-comment=debug builds show some additional E_NOTICE errors
 upload_max_filesize=1024
 session.save_path=
 session.name=PHPSESSID
@@ -42,7 +40,7 @@ Content-Disposition: form-data; name="file2"; filename="file2.txt"
 session_start();
 var_dump(session_id());
 var_dump($_FILES);
-var_dump($_SESSION["upload_progress_" . basename(__FILE__)]);
+var_dump(isset($_SESSION["upload_progress_" . basename(__FILE__)]));
 session_destroy();
 ?>
 --EXPECTF--
@@ -75,4 +73,4 @@ array(2) {
     int(1)
   }
 }
-NULL
+bool(false)
index 10afe8f19db81e8d39a2ef5e0cbf87bb73fcca80..d63748369d2c8059327883de79ac2fae338d5382 100644 (file)
@@ -2,8 +2,6 @@
 session rfc1867 disabled 2
 --INI--
 file_uploads=1
-error_reporting=E_ALL&~E_NOTICE
-comment=debug builds show some additional E_NOTICE errors
 upload_max_filesize=1024
 session.save_path=
 session.name=PHPSESSID
@@ -42,7 +40,7 @@ Content-Disposition: form-data; name="file2"; filename="file2.txt"
 session_start();
 var_dump(session_id());
 var_dump($_FILES);
-var_dump($_SESSION["upload_progress_" . basename(__FILE__)]);
+var_dump(isset($_SESSION["upload_progress_" . basename(__FILE__)]));
 session_destroy();
 ?>
 --EXPECTF--
@@ -75,4 +73,4 @@ array(2) {
     int(1)
   }
 }
-NULL
+bool(false)
index 577591feda2891fe0fbda9756a73c0ccb475d8cc..b961bbcac3053d0cfcec7908b633895f8c82500b 100644 (file)
@@ -2,8 +2,6 @@
 session rfc1867
 --INI--
 file_uploads=1
-error_reporting=E_ALL&~E_NOTICE
-comment=debug builds show some additional E_NOTICE errors
 upload_max_filesize=1024
 session.save_path=
 session.name=PHPSESSID
@@ -52,7 +50,7 @@ session_start();
 var_dump(session_id());
 var_dump($_FILES);
 var_dump($_SESSION["upload_progress_" . basename(__FILE__) . "_1"]);
-var_dump($_SESSION["upload_progress_" . basename(__FILE__) . "_2"]);
+var_dump(isset($_SESSION["upload_progress_" . basename(__FILE__) . "_2"]));
 session_destroy();
 ?>
 --EXPECTF--
@@ -132,4 +130,4 @@ array(5) {
     }
   }
 }
-NULL
+bool(false)
index e34f776f12fa02372194be5d70dea1386692a212..98e8e7cf0988bb4980e431470476868b854f34ef 100644 (file)
@@ -2,8 +2,6 @@
 session rfc1867 no name
 --INI--
 file_uploads=1
-error_reporting=E_ALL&~E_NOTICE
-comment=debug builds show some additional E_NOTICE errors
 upload_max_filesize=1024
 session.save_path=
 session.name=PHPSESSID
@@ -42,7 +40,7 @@ Content-Disposition: form-data; name="file2"; filename="file2.txt"
 session_start();
 var_dump(session_id());
 var_dump($_FILES);
-var_dump($_SESSION["upload_progress_" . basename(__FILE__)]);
+var_dump(isset($_SESSION["upload_progress_" . basename(__FILE__)]));
 session_destroy();
 ?>
 --EXPECTF--
@@ -75,4 +73,4 @@ array(2) {
     int(1)
   }
 }
-NULL
+bool(false)
index 6a58172f908422bd52f3ca10b1c2b94b19d9eeb6..804a9ba3084b32e4743c5c4070a97065d4da2aaf 100644 (file)
@@ -2,8 +2,6 @@
 session rfc1867 sid cookie
 --INI--
 file_uploads=1
-error_reporting=E_ALL&~E_NOTICE
-comment=debug builds show some additional E_NOTICE errors
 upload_max_filesize=1024
 session.save_path=
 session.name=PHPSESSID
index 089eefe9673c980f969cd290fbc5d48bc0ec1609..17d1ebce0f5adbeb136e6508daf97fa2adf3c319 100644 (file)
@@ -2,8 +2,6 @@
 session rfc1867 sid get
 --INI--
 file_uploads=1
-error_reporting=E_ALL&~E_NOTICE
-comment=debug builds show some additional E_NOTICE errors
 upload_max_filesize=1024
 session.save_path=
 session.name=PHPSESSID
index 7cb2ffb17a7665ddfaa38bd0c0450ca0a903e81d..4b32c6e3528713d1f3ba373682767201327f603a 100644 (file)
@@ -2,8 +2,6 @@
 session rfc1867 sid get 2
 --INI--
 file_uploads=1
-error_reporting=E_ALL&~E_NOTICE
-comment=debug builds show some additional E_NOTICE errors
 upload_max_filesize=1024
 session.save_path=
 session.name=PHPSESSID
index 881b1d5bb4aa215e72375a3daf8b8ee74a4efd00..b75a9f64708d35b84cd0a8bc2a175e9287509262 100644 (file)
@@ -2,8 +2,6 @@
 session rfc1867 sid cookie
 --INI--
 file_uploads=1
-error_reporting=E_ALL&~E_NOTICE
-comment=debug builds show some additional E_NOTICE errors
 upload_max_filesize=1024
 session.save_path=
 session.name=PHPSESSID
index f8f20fc3d89c47ec6c9fe42953c8e1c30229b6d6..0c376bb026a5377167815a262f853d49b57b8a42 100644 (file)
@@ -2,8 +2,6 @@
 session rfc1867 sid only cookie
 --INI--
 file_uploads=1
-error_reporting=E_ALL&~E_NOTICE
-comment=debug builds show some additional E_NOTICE errors
 upload_max_filesize=1024
 session.save_path=
 session.name=PHPSESSID
index e98f4c4e3f7974621c7db99a9cfa9197fc6e3bed..9b0aae9429af34511a128bfdd734e38637a99012 100644 (file)
@@ -2,8 +2,6 @@
 session rfc1867 sid only cookie 2
 --INI--
 file_uploads=1
-error_reporting=E_ALL&~E_NOTICE
-comment=debug builds show some additional E_NOTICE errors
 upload_max_filesize=1024
 session.save_path=
 session.name=PHPSESSID
@@ -44,7 +42,7 @@ session_start();
 var_dump(session_id());
 var_dump(basename(__FILE__) == $_POST[ini_get("session.upload_progress.name")]);
 var_dump($_FILES);
-var_dump($_SESSION["upload_progress_" . basename(__FILE__)]);
+var_dump(isset($_SESSION["upload_progress_" . basename(__FILE__)]));
 session_destroy();
 ?>
 --EXPECTF--
@@ -78,4 +76,4 @@ array(2) {
     int(1)
   }
 }
-NULL
+bool(false)
index 51a97b900e0d6cd9665a83839f2f345bd8dfd946..a126f9ba386f7136da3e13ef6dc97bf51dd75e81 100644 (file)
@@ -2,8 +2,6 @@
 session rfc1867 sid post
 --INI--
 file_uploads=1
-error_reporting=E_ALL&~E_NOTICE
-comment=debug builds show some additional E_NOTICE errors
 upload_max_filesize=1024
 session.save_path=
 session.name=PHPSESSID