lib: remove unused code

This fixes the following clang warnings:
macro is not used [-Wunused-macros]
will never be executed [-Wunreachable-code]

Closes https://github.com/curl/curl/pull/1448

diff --git a/lib/formdata.c b/lib/formdata.c
index 2a934344ebc4e86dbab0bd7abd21f95f3c6505d2..90fbd11437546a0aed88a65eb6d52d54b18cd0c0 100644 (file)
--- a/lib/formdata.c
+++ b/lib/formdata.c
@@ -54,9 +54,6 @@ static char *formboundary(struct Curl_easy *data);
    extensions. */
 #define HTTPPOST_CONTENTTYPE_DEFAULT "application/octet-stream"
 
-#define FORM_FILE_SEPARATOR ','
-#define FORM_TYPE_SEPARATOR ';'
-
 #define HTTPPOST_PTRNAME CURL_HTTPPOST_PTRNAME
 #define HTTPPOST_FILENAME CURL_HTTPPOST_FILENAME
 #define HTTPPOST_PTRCONTENTS CURL_HTTPPOST_PTRCONTENTS

diff --git a/lib/hostip.c b/lib/hostip.c
index ed18763fda33ec88da9b94c2708127a709ebe1f7..21baf601544ecffb5236affb11542b7b16889331 100644 (file)
--- a/lib/hostip.c
+++ b/lib/hostip.c
@@ -538,7 +538,6 @@ RETSIGTYPE alarmfunc(int sig)
   /* this is for "-ansi -Wall -pedantic" to stop complaining!   (rabe) */
   (void)sig;
   siglongjmp(curl_jmpenv, 1);
-  return;
 }
 #endif /* USE_ALARM_TIMEOUT */
 

diff --git a/lib/mprintf.c b/lib/mprintf.c
index 6b7d317f8048ead5868ce81e0ac33fbc8550374d..6d4e733f0c6c1bcf17a773eca5f6a756198125ed 100644 (file)
--- a/lib/mprintf.c
+++ b/lib/mprintf.c
@@ -42,10 +42,6 @@
 /* The last #include file should be: */
 #include "memdebug.h"
 
-#ifndef SIZEOF_LONG_DOUBLE
-#define SIZEOF_LONG_DOUBLE 0
-#endif
-
 /*
  * If SIZEOF_SIZE_T has not been defined, default to the size of long.
  */

diff --git a/lib/telnet.c b/lib/telnet.c
index 5cceed258188bd8ebb18f844530d86fb09374ffd..bbdbb86ad84d86efbba4274ed0e5415ba10b62c5 100644 (file)
--- a/lib/telnet.c
+++ b/lib/telnet.c
@@ -81,10 +81,12 @@
   } WHILE_FALSE
 
 #define  CURL_SB_GET(x) ((*x->subpointer++)&0xff)
-#define  CURL_SB_PEEK(x)   ((*x->subpointer)&0xff)
-#define  CURL_SB_EOF(x) (x->subpointer >= x->subend)
 #define  CURL_SB_LEN(x) (x->subend - x->subpointer)
 
+/* For posterity:
+#define  CURL_SB_PEEK(x) ((*x->subpointer)&0xff)
+#define  CURL_SB_EOF(x) (x->subpointer >= x->subend) */
+
 #ifdef CURL_DISABLE_VERBOSE_STRINGS
 #define printoption(a,b,c,d)  Curl_nop_stmt
 #endif

diff --git a/lib/url.c b/lib/url.c
index 6795a9c8f451880443f6487bcf97a9d35d932cd5..f5998d6b113b451a072ef354b398e92939cc8cef 100644 (file)
--- a/lib/url.c
+++ b/lib/url.c
@@ -2935,8 +2935,7 @@ static void conn_reset_all_postponed_data(struct connectdata *conn)
   conn_reset_postponed_data(conn, 1);
 }
 #else  /* ! USE_RECV_BEFORE_SEND_WORKAROUND */
-/* Use "do-nothing" macros instead of functions when workaround not used */
-#define conn_reset_postponed_data(c,n) do {} WHILE_FALSE
+/* Use "do-nothing" macro instead of function when workaround not used */
 #define conn_reset_all_postponed_data(c) do {} WHILE_FALSE
 #endif /* ! USE_RECV_BEFORE_SEND_WORKAROUND */