]> granicus.if.org Git - libevent/commitdiff
Fix "Value stored to 'a' is never read" in SHA1Transform()
authorCœur <coeur@gmx.fr>
Thu, 2 Mar 2023 06:07:44 +0000 (14:07 +0800)
committerAzat Khuzhin <azat@libevent.org>
Thu, 2 Mar 2023 06:29:18 +0000 (07:29 +0100)
Using same fix as used in android [1].

  [1]: android.googlesource.com/platform/dalvik/+/android-4.4.2_r2/libdex/sha1.cpp#193

sha1.c

diff --git a/sha1.c b/sha1.c
index 09cf6e695aca6a1cf0ca6a09741ae15f62d3182b..dd88f103377e4bc2ff17091eb0fa9c5e896e27ce 100644 (file)
--- a/sha1.c
+++ b/sha1.c
@@ -198,8 +198,6 @@ static void SHA1Transform(uint32_t state[5], const unsigned char buffer[64]) {
     state[2] += c;
     state[3] += d;
     state[4] += e;
-    /* Wipe variables */
-    a = b = c = d = e = 0;
 #ifdef SHA1HANDSOFF
     memset(block, '\0', sizeof(block));
 #endif