Avoid needless string duplication

Cf. <https://github.com/php/php-src/pull/3636#issuecomment-436638833>.

diff --git a/ext/sqlite3/sqlite3.c b/ext/sqlite3/sqlite3.c
index 2abf99f4ebd1efdd41f90abadee70a6a2d5e4cc5..1b24af074f399f4c585490dd12743f5828e59f51 100644 (file)
--- a/ext/sqlite3/sqlite3.c
+++ b/ext/sqlite3/sqlite3.c
@@ -1415,7 +1415,7 @@ static int register_bound_parameter_to_sqlite(struct php_sqlite3_bound_param *pa
                        memmove(ZSTR_VAL(temp) + 1, ZSTR_VAL(param->name), ZSTR_LEN(param->name) + 1);
                        param->name = temp;
                } else {
-                       param->name = zend_string_init(ZSTR_VAL(param->name), ZSTR_LEN(param->name), 0);
+                       param->name = zend_string_copy(param->name);
                }
                /* do lookup*/
                param->param_number = sqlite3_bind_parameter_index(stmt->stmt, ZSTR_VAL(param->name));