]> granicus.if.org Git - handbrake/commitdiff
MacGui: made some HBJob properties private.
authorDamiano Galassi <damiog@gmail.com>
Mon, 31 Oct 2016 16:50:36 +0000 (17:50 +0100)
committerDamiano Galassi <damiog@gmail.com>
Mon, 31 Oct 2016 16:50:36 +0000 (17:50 +0100)
macosx/HBAudio.h
macosx/HBAudio.m
macosx/HBJob+Private.h
macosx/HBPicture.h
macosx/HBSubtitles.h
macosx/HBSubtitles.m
macosx/HBVideo+UIAdditions.m
macosx/HBVideo.h
macosx/HBVideo.m

index 5d73830a746824f6e5a634823bd37f7413aeb5e2..aaaf076edc8e9558ee15ea7383e23c98cf04894f 100644 (file)
@@ -7,7 +7,6 @@
 #import <Foundation/Foundation.h>
 #import "HBPresetCoding.h"
 
-@class HBJob;
 @class HBAudioTrack;
 @class HBAudioDefaults;
 
@@ -17,10 +16,6 @@ extern NSString *HBAudioChangedNotification;
 
 @interface HBAudio : NSObject <NSSecureCoding, NSCopying>
 
-- (instancetype)initWithJob:(HBJob *)job;
-
-@property (nonatomic, readwrite, weak) HBJob *job;
-
 @property (nonatomic, readonly) NSMutableArray<NSDictionary *> *sourceTracks;
 @property (nonatomic, readonly) NSMutableArray<HBAudioTrack *> *tracks;
 
@@ -32,7 +27,6 @@ extern NSString *HBAudioChangedNotification;
 
 - (BOOL)anyCodecMatches:(int)codec;
 
-@property (nonatomic, readwrite) int container;
 @property (nonatomic, readwrite, weak, nullable) NSUndoManager *undo;
 
 @end
index 6c6bda46c9369114328b3a4ceed41f2b9c5ca6e4..7d92c5942796299c52310ad4f652947ca2b42272 100644 (file)
 NSString *HBAudioChangedNotification = @"HBAudioChangedNotification";
 
 @interface HBAudio () <HBAudioTrackDataSource, HBAudioTrackDelegate>
+
+@property (nonatomic, readwrite, weak) HBJob *job;
+@property (nonatomic, readwrite) int container;
+
 @end
 
 @implementation HBAudio
index acd78da1fdc9b71c32c6713a0ff5b0ce0bd5692e..2479516e60a255d4979f89f6aad71b872b1d9745 100644 (file)
 
 @interface HBVideo (Private)
 
+- (instancetype)initWithJob:(HBJob *)job;
+
+@property (nonatomic, readwrite, weak) HBJob *job;
+
+- (void)containerChanged;
 - (void)applyPreset:(HBPreset *)preset jobSettings:(NSDictionary *)settings;
 
 @end
 
 @interface HBPicture (Private)
 
+- (instancetype)initWithTitle:(HBTitle *)title;
+
 - (void)applyPreset:(HBPreset *)preset jobSettings:(NSDictionary *)settings;
 
 @end
 
 @interface HBAudio (Private)
 
+- (instancetype)initWithJob:(HBJob *)job;
+
+@property (nonatomic, readwrite, weak) HBJob *job;
+@property (nonatomic, readwrite) int container;
+
 - (void)applyPreset:(HBPreset *)preset jobSettings:(NSDictionary *)settings;
 
 @end
 
 @interface HBSubtitles (Private)
 
+- (instancetype)initWithJob:(HBJob *)job;
+
+@property (nonatomic, readwrite, weak) HBJob *job;
+@property (nonatomic, readwrite) int container;
+
 - (void)applyPreset:(HBPreset *)preset jobSettings:(NSDictionary *)settings;
 
 @end
index 2b0dc9503491affd989333aad7198ecb6a647cb7..e22f164c5b581549a13f7bf5dd29b410aef3c19b 100644 (file)
@@ -25,8 +25,6 @@ extern NSString * const HBPictureChangedNotification;
  */
 @interface HBPicture : NSObject <NSSecureCoding, NSCopying>
 
-- (instancetype)initWithTitle:(HBTitle *)title;
-
 @property (nonatomic, readwrite) int width;
 @property (nonatomic, readwrite) int height;
 
index afda6a659ad87c1d4646293e50da36fad5bdc0f6..0d5d87a3067da60768cff18879b6f99dd9b2b47b 100644 (file)
@@ -9,16 +9,11 @@
 
 NS_ASSUME_NONNULL_BEGIN
 
-@class HBJob;
 @class HBSubtitlesTrack;
 @class HBSubtitlesDefaults;
 
 @interface HBSubtitles : NSObject <NSSecureCoding, NSCopying>
 
-- (instancetype)initWithJob:(HBJob *)job;
-
-@property (nonatomic, readwrite, weak) HBJob *job;
-
 - (void)addAllTracks;
 - (void)removeAll;
 - (void)reloadDefaults;
@@ -30,10 +25,6 @@ NS_ASSUME_NONNULL_BEGIN
 
 @property (nonatomic, readwrite, strong) HBSubtitlesDefaults *defaults;
 
-/**
- *  For internal use
- */
-@property (nonatomic, readwrite) int container;
 @property (nonatomic, readwrite, weak, nullable) NSUndoManager *undo;
 
 @end
index b920623ff6797a1a3565541e25d70ea81909c125..024d30dcfe2307ab0c29a4d32f416d11def57106 100644 (file)
@@ -28,6 +28,9 @@ extern NSString *keySubTrackSrtFileURL;
 
 @interface HBSubtitles () <HBTrackDataSource, HBTrackDelegate>
 
+@property (nonatomic, readwrite, weak) HBJob *job;
+@property (nonatomic, readwrite) int container;
+
 /// Used to aovid circular dependecy validation.
 @property (nonatomic, readwrite) BOOL validating;
 
@@ -40,7 +43,7 @@ extern NSString *keySubTrackSrtFileURL;
     self = [super init];
     if (self)
     {
-        _job = job;
+        job = job;
         _container = HB_MUX_MP4;
 
         _sourceTracks = [job.title.subtitlesTracks mutableCopy];
index 676746b7cc405c8d8e46b26b888fbbc20c1b8df2..1a07bb8101a53a68355031cd2f8bf4b93baffac4 100644 (file)
@@ -5,7 +5,7 @@
  It may be used under the terms of the GNU General Public License. */
 
 #import "HBVideo+UIAdditions.h"
-#import "HBJob.h"
+#import "HBJob+Private.h"
 #include "hb.h"
 
 @implementation HBVideo (UIAdditions)
index 50678ec41aed976c5359a56d7d0384607479d975..d259f011c3d44ff37e1a971d6a0c98a8c4c02b48 100644 (file)
@@ -28,12 +28,6 @@ extern NSString * const HBVideoChangedNotification;
  */
 @interface HBVideo : NSObject <NSSecureCoding, NSCopying>
 
-- (instancetype)initWithJob:(HBJob *)job;
-
-@property (nonatomic, readwrite, weak) HBJob *job;
-
-- (void)containerChanged;
-
 @property (nonatomic, readwrite) int encoder;
 
 @property (nonatomic, readwrite) HBVideoQualityType qualityType;
index d1641087e987d37b97e43dc0b4af411fef735845..6dfc16325e2718d8beaed7cc5c02df8268d9c75d 100644 (file)
@@ -15,6 +15,8 @@ NSString * const HBVideoChangedNotification = @"HBVideoChangedNotification";
 
 @interface HBVideo ()
 
+@property (nonatomic, readwrite, weak) HBJob *job;
+
 @property (nonatomic, readwrite) double qualityMinValue;
 @property (nonatomic, readwrite) double qualityMaxValue;