patch 7.4.1379

Problem:    Channel test fails on Win32 console.
Solution:   Don't sleep when timeout is zero. Call channel_wait() before
            channel_read(). Channels are not polled during ":sleep". (Yukihiro
            Nakadaira)

diff --git a/src/channel.c b/src/channel.c
index aa478f16ccb8f8dfe3a5a015115df3b9bac3c23d..d02f0197ef62e2305e2040083b22fa09eefaa1a3 100644 (file)
--- a/src/channel.c
+++ b/src/channel.c
@@ -1582,7 +1582,7 @@ channel_wait(channel_T *channel, sock_T fd, int timeout)
                                                                 && nread > 0)
                return OK;
            diff = deadline - GetTickCount();
-           if (diff < 0)
+           if (diff <= 0)
                break;
            /* Wait for 5 msec.
             * TODO: increase the sleep time when looping more often */
@@ -1881,17 +1881,19 @@ channel_fd2channel(sock_T fd, int *partp)
        }
     return NULL;
 }
+# endif
 
+# if defined(WIN32) || defined(PROTO)
+/*
+ * Check the channels for anything that is ready to be read.
+ * The data is put in the read queue.
+ */
     void
 channel_handle_events(void)
 {
     channel_T  *channel;
     int                part;
-    static int loop = 0;
-
-    /* Skip heavily polling */
-    if (loop++ % 2)
-       return;
+    sock_T     fd;
 
     for (channel = first_channel; channel != NULL; channel = channel->ch_next)
     {
@@ -1907,7 +1909,11 @@ channel_handle_events(void)
        part = PART_SOCK;
 #   endif
 #  endif
-       channel_read(channel, part, "channel_handle_events");
+       {
+           fd = channel->ch_part[part].ch_fd;
+           if (fd != INVALID_FD && channel_wait(channel, fd, 0) == OK)
+               channel_read(channel, part, "channel_handle_events");
+       }
     }
 }
 # endif

diff --git a/src/gui_w32.c b/src/gui_w32.c
index f3da79425e5086244f9555158f2e22a21170d9be..3a64691493bfe345a0f238ca4133166aa9d3605b 100644 (file)
--- a/src/gui_w32.c
+++ b/src/gui_w32.c
@@ -2248,10 +2248,6 @@ gui_mch_wait_for_chars(int wtime)
        parse_queued_messages();
 #endif
 
-#ifdef FEAT_CHANNEL
-       channel_handle_events();
-#endif
-
        /*
         * Don't use gui_mch_update() because then we will spin-lock until a
         * char arrives, instead we use GetMessage() to hang until an

diff --git a/src/misc2.c b/src/misc2.c
index 9cfb118179dd18c416fac0c663d611e3ef4bb2f0..932d67e7813054a1945a959269131e82fc1aa35e 100644 (file)
--- a/src/misc2.c
+++ b/src/misc2.c
@@ -6239,6 +6239,11 @@ has_non_ascii(char_u *s)
     void
 parse_queued_messages(void)
 {
+    /* For Win32 mch_breakcheck() does not check for input, do it here. */
+# if defined(WIN32) && defined(FEAT_CHANNEL)
+    channel_handle_events();
+# endif
+
 # ifdef FEAT_NETBEANS_INTG
     /* Process the queued netbeans messages. */
     netbeans_parse_messages();

diff --git a/src/os_win32.c b/src/os_win32.c
index ae1f0d8afc198cdb4924236c23298dbef862333d..631f88e49584f9d6995c58f4d7a3ee8c7630f2b9 100644 (file)
--- a/src/os_win32.c
+++ b/src/os_win32.c
@@ -1470,10 +1470,6 @@ WaitForChar(long msec)
        serverProcessPendingMessages();
 #endif
 
-#ifdef FEAT_CHANNEL
-       channel_handle_events();
-#endif
-
        if (0
 #ifdef FEAT_MOUSE
                || g_nMouseClick != -1

diff --git a/src/version.c b/src/version.c
index 748371fc6fa7e529bfa78b275a33d03cad206ea4..b5f482536824355b30138a93f04b25d4c4b60518 100644 (file)
--- a/src/version.c
+++ b/src/version.c
@@ -747,6 +747,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    1379,
 /**/
     1378,
 /**/