]> granicus.if.org Git - python/commitdiff
bpo-33676: Fix dangling thread in _test_multiprocessing (GH-10755)
authorVictor Stinner <vstinner@redhat.com>
Wed, 28 Nov 2018 00:14:31 +0000 (01:14 +0100)
committerGitHub <noreply@github.com>
Wed, 28 Nov 2018 00:14:31 +0000 (01:14 +0100)
Fix WithThreadsTestPool.test_wrapped_exception()
of test_multiprocessing_fork: join the pool.

WithThreadsTestPool.test_del_pool() is now also decorated
with @support.reap_threads.

Lib/test/_test_multiprocessing.py

index 4302708c14f1b692cc9a7480aa8e30ee8edbb50f..b62c119e9ae0694290a410f3cee1e3316ee8bdea 100644 (file)
@@ -2522,6 +2522,7 @@ class _TestPool(BaseTestCase):
         with self.Pool(1) as p:
             with self.assertRaises(RuntimeError):
                 p.apply(self._test_wrapped_exception)
+        p.join()
 
     def test_map_no_failfast(self):
         # Issue #23992: the fail-fast behaviour when an exception is raised
@@ -2557,6 +2558,7 @@ class _TestPool(BaseTestCase):
         # they were released too.
         self.assertEqual(CountedObject.n_instances, 0)
 
+    @support.reap_threads
     def test_del_pool(self):
         p = self.Pool(1)
         wr = weakref.ref(p)