]> granicus.if.org Git - handbrake/commitdiff
dvdnav: fix potentially unterminated string
authorJohn Stebbins <jstebbins.hb@gmail.com>
Mon, 11 Feb 2019 15:08:21 +0000 (08:08 -0700)
committerJohn Stebbins <jstebbins.hb@gmail.com>
Mon, 11 Feb 2019 15:19:59 +0000 (08:19 -0700)
(cherry picked from commit a54f09a9f1a292ac3b9e6699ea09d8e0239e6f7b)

libhb/dvdnav.c

index 5a3782cbb91b1639c44cf7b86889440c171eb8b1..9eb5534ed9b4ab58bc8265404172a7fc82981bb2 100644 (file)
@@ -457,7 +457,8 @@ static hb_title_t * hb_dvdnav_title_scan( hb_dvd_t * e, int t, uint64_t min_dura
     title->type = HB_DVD_TYPE;
     if (dvdnav_get_title_string(d->dvdnav, &name) == DVDNAV_STATUS_OK)
     {
-        strncpy( title->name, name, sizeof( title->name ) );
+        strncpy(title->name, name, sizeof(title->name) - 1);
+        title->name[sizeof(title->name) - 1] = 0;
     }
 
     if (strlen(title->name) == 0)