ui-clone.c: Fix path check

The starts_with() check was broken in two ways: For one thing, the
parameters were passed in the wrong order, for another thing,
starts_with() returns 1 if the string starts with the prefix (not 0).

Note that this bug existed since commit 02a545e (Add support for cloning
over http, 2008-08-06) but only pops in in corner cases.

Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>

diff --git a/ui-clone.c b/ui-clone.c
index 50569d6075f6ef94a3c4ebbd465ff648fb5b7486..1e6238d08eb2c48da6bac5ddaba5e71bea47f199 100644 (file)
--- a/ui-clone.c
+++ b/ui-clone.c
@@ -63,8 +63,8 @@ static void send_file(char *path)
        }
        ctx.page.mimetype = "application/octet-stream";
        ctx.page.filename = path;
-       if (!starts_with(ctx.repo->path, path))
-               ctx.page.filename += strlen(ctx.repo->path) + 1;
+       skip_prefix(path, ctx.repo->path, &ctx.page.filename);
+       skip_prefix(ctx.page.filename, "/", &ctx.page.filename);
        cgit_print_http_headers();
        html_include(path);
 }