Issue #21868: Prevent turtle crash due to invalid undo buffer size.

diff --git a/Lib/lib-tk/turtle.py b/Lib/lib-tk/turtle.py
index 6a9071594fb3800d300645bed63081888d887e40..75673a4bcb81d40113d2185b3cb5ad7d42c1e6b4 100644 (file)
--- a/Lib/lib-tk/turtle.py
+++ b/Lib/lib-tk/turtle.py
@@ -2499,7 +2499,7 @@ class RawTurtle(TPen, TNavigator):
         Example (for a Turtle instance named turtle):
         >>> turtle.setundobuffer(42)
         """
-        if size is None:
+        if size is None or size <= 0:
             self.undobuffer = None
         else:
             self.undobuffer = Tbuffer(size)

diff --git a/Misc/ACKS b/Misc/ACKS
index 27be9493f08cd7fdccab2345f4673ca708215ec0..2dc0e779ddbabf746336fad43f3d4449a7e95374 100644 (file)
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -235,6 +235,7 @@ Ingrid Cheung
 Albert Chin-A-Young
 Adal Chiriliuc
 Matt Chisholm
+Lita Cho
 Anders Chrigström
 Tom Christiansen
 Renee Chu

diff --git a/Misc/NEWS b/Misc/NEWS
index 9ba62e87806912320ec8a0ec6e130d48feef9bab..0181a4614ee325f60c6ea21f25ab4751d879e20c 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -16,6 +16,9 @@ Library
 - Issue #22017: Correct reference counting errror in the initialization of the
   _warnings module.
 
+- Issue #21868: Prevent turtle crash when undo buffer set to a value less
+  than one.
+
 - Issue #21044: tarfile.open() now handles fileobj with an integer 'name'
   attribute.  Based on patch by Martin Panter.