]> granicus.if.org Git - python/commitdiff
bpo-31044, test_posix: Reenable makedev() tests on FreeBSD (#7449)
authorVictor Stinner <vstinner@redhat.com>
Wed, 6 Jun 2018 13:28:50 +0000 (15:28 +0200)
committerGitHub <noreply@github.com>
Wed, 6 Jun 2018 13:28:50 +0000 (15:28 +0200)
The bug has been fixed 10 months ago:

* https://svnweb.freebsd.org/base?view=revision&revision=321920
* https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221048

Lib/test/test_posix.py

index e54484ce7da2c64c4045a2d3dec53af2ba504149..4f6abc6f7d6fd930e4f7b2e431930ac6e4e0e016 100644 (file)
@@ -615,11 +615,6 @@ class PosixTester(unittest.TestCase):
         self.assertRaises(TypeError, posix.minor)
         self.assertRaises((ValueError, OverflowError), posix.minor, -1)
 
-        # FIXME: reenable these tests on FreeBSD with the kernel fix
-        if sys.platform.startswith('freebsd') and dev >= 0x1_0000_0000:
-            self.skipTest("bpo-31044: on FreeBSD CURRENT, minor() truncates "
-                          "64-bit dev to 32-bit")
-
         self.assertEqual(posix.makedev(major, minor), dev)
         self.assertRaises(TypeError, posix.makedev, float(major), minor)
         self.assertRaises(TypeError, posix.makedev, major, float(minor))