Some more test-size-estimate fixes: test_append and test_insert trigger a

list resize, which overallocates.

diff --git a/Lib/test/test_bigmem.py b/Lib/test/test_bigmem.py
index bb7bb5493b88e47fa3df6407439b4cd3f87a86de..1d610e57e6ab314455396ca1e5854217142c577e 100644 (file)
--- a/Lib/test/test_bigmem.py
+++ b/Lib/test/test_bigmem.py
@@ -833,8 +833,9 @@ class ListTest(unittest.TestCase):
     def test_repr_large(self, size):\r
         return self.basic_test_repr(size)\r
 \r
-\r
-    @bigmemtest(minsize=_2G, memuse=8)\r
+    # list overallocates ~1/8th of the total size (on first expansion) so\r
+    # the single list.append call puts memuse at 9 bytes per size.\r
+    @bigmemtest(minsize=_2G, memuse=9)\r
     def test_append(self, size):\r
         l = [object()] * size\r
         l.append(object())\r
@@ -872,7 +873,8 @@ class ListTest(unittest.TestCase):
         self.assertRaises(ValueError, l.index, 1, size - 4, size)\r
         self.assertRaises(ValueError, l.index, 6L)\r
 \r
-    @bigmemtest(minsize=_2G + 10, memuse=8)\r
+    # This tests suffers from overallocation, just like test_append.\r
+    @bigmemtest(minsize=_2G + 10, memuse=9)\r
     def test_insert(self, size):\r
         l = [1.0] * size\r
         l.insert(size - 1, "A")\r
@@ -920,6 +922,8 @@ class ListTest(unittest.TestCase):
         size -= 1\r
         self.assertEquals(len(l), size)\r
 \r
+        # Because of the earlier l.remove(), this append doesn't trigger\r
+        # a resize.\r
         l.append(5)\r
         size += 1\r
         self.assertEquals(len(l), size)\r