]> granicus.if.org Git - python/commitdiff
Fix the patch for issue #7978: select() raises select.error before 3.3, not OSError.
authorAntoine Pitrou <solipsis@pitrou.net>
Sun, 8 Apr 2012 23:41:34 +0000 (01:41 +0200)
committerAntoine Pitrou <solipsis@pitrou.net>
Sun, 8 Apr 2012 23:41:34 +0000 (01:41 +0200)
Lib/SocketServer.py
Lib/test/test_socketserver.py

index a44e1378547570176336d27307b41f17205e4f70..1594321909c149586da5ceeb4f41cfafdd2f6e3e 100644 (file)
@@ -153,8 +153,8 @@ def _eintr_retry(func, *args):
     while True:
         try:
             return func(*args)
-        except OSError as e:
-            if e.errno != errno.EINTR:
+        except (OSError, select.error) as e:
+            if e.args[0] != errno.EINTR:
                 raise
 
 class BaseServer:
index 3c7287a0812f438726f1edd57ea6caa6b1a3efd2..3b333bc7f5c0f4e23993191455012453b6e9284e 100644 (file)
@@ -243,7 +243,7 @@ class SocketServerTest(unittest.TestCase):
                 self.called += 1
                 if self.called == 1:
                     # raise the exception on first call
-                    raise OSError(errno.EINTR, os.strerror(errno.EINTR))
+                    raise select.error(errno.EINTR, os.strerror(errno.EINTR))
                 else:
                     # Return real select value for consecutive calls
                     return old_select(*args)