Eino Tuominen improved the code when a file is used to seed the randomizer

diff --git a/ares/CHANGES b/ares/CHANGES
index d33eba4f638da748c8773a172e3e1294206828cc..a54ba41d4f134b6ee1a97f23e2b95ca7aac3a80f 100644 (file)
--- a/ares/CHANGES
+++ b/ares/CHANGES
@@ -1,5 +1,9 @@
   Changelog for the c-ares project
 
+* April 4 2008 (Daniel Stenberg)
+
+- Eino Tuominen improved the code when a file is used to seed the randomizer.
+
 * December 11 2007 (Gisle Vanem)
 
 - Added another sample application; acountry.c which converts an

diff --git a/ares/ares_init.c b/ares/ares_init.c
index 0110f12794b5223a78c00a253f0a8b15f896c22b..583f98f45a10da7f5789122ff60ad87395427745 100644 (file)
--- a/ares/ares_init.c
+++ b/ares/ares_init.c
@@ -1333,13 +1333,9 @@ static void randomize_key(unsigned char* key,int key_data_len)
   }
 #else /* !WIN32 */
 #ifdef RANDOM_FILE
-  char buffer[256];
   FILE *f = fopen(RANDOM_FILE, "rb");
   if(f) {
-    size_t i;
-    size_t rc = fread(buffer, key_data_len, 1, f);
-    for(i=0; i<rc && counter < key_data_len; i++)
-      key[counter++]=buffer[i];
+    counter = fread(key, 1, key_data_len, f);
     fclose(f);
   }
 #endif