bpo-12414: Update code_sizeof() to take in account co_extra memory. (#1168)

diff --git a/Lib/test/test_sys.py b/Lib/test/test_sys.py
index 748445eb5b61a4899a73bc89e9e6eb363dba0ef8..ed78e2a0f9aea3fd82abee8646594fd644b5df9f 100644 (file)
--- a/Lib/test/test_sys.py
+++ b/Lib/test/test_sys.py
@@ -922,13 +922,15 @@ class SizeofTest(unittest.TestCase):
             return inner
         check(get_cell().__closure__[0], size('P'))
         # code
-        check(get_cell().__code__, size('6i13P'))
-        check(get_cell.__code__, size('6i13P'))
+        def check_code_size(a, expected_size):
+            self.assertGreaterEqual(sys.getsizeof(a), expected_size)
+        check_code_size(get_cell().__code__, size('6i13P'))
+        check_code_size(get_cell.__code__, size('6i13P'))
         def get_cell2(x):
             def inner():
                 return x
             return inner
-        check(get_cell2.__code__, size('6i13P') + calcsize('n'))
+        check_code_size(get_cell2.__code__, size('6i13P') + calcsize('n'))
         # complex
         check(complex(0,1), size('2d'))
         # method_descriptor (descriptor object)

diff --git a/Misc/ACKS b/Misc/ACKS
index 8c4439721ea3f77f594d4151892c7bc1e1609a0d..d4f20c548f66d539e43dcb97ac3f85eef361eea2 100644 (file)
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -1063,6 +1063,7 @@ R. David Murray
 Matti Mäki
 Jörg Müller
 Kaushik N
+Dong-hee Na
 Dale Nagata
 John Nagle
 Takahiro Nakayama

diff --git a/Misc/NEWS b/Misc/NEWS
index 3ec02e0e3e8ef6129ae2949432d88b5d04330825..7e09eff4e0a238724cbdd76667035aa5763a5b6f 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -10,6 +10,10 @@ What's New in Python 3.7.0 alpha 1?
 Core and Builtins
 -----------------
 
+- bpo-12414: sys.getsizeof() on a code object now returns the sizes 
+  which includes the code struct and sizes of objects which it references.
+  Patch by Dong-hee Na.
+
 - bpo-29839: len() now raises ValueError rather than OverflowError if
   __len__() returned a large negative integer.
 

diff --git a/Objects/codeobject.c b/Objects/codeobject.c
index ebc70669fecb612e4d8cee59c65b154647dbc9c9..46bc45d5ac186d10d65a08a01ff395625399c7da 100644 (file)
--- a/Objects/codeobject.c
+++ b/Objects/codeobject.c
@@ -451,11 +451,15 @@ code_dealloc(PyCodeObject *co)
 static PyObject *
 code_sizeof(PyCodeObject *co, void *unused)
 {
-    Py_ssize_t res;
+    Py_ssize_t res = _PyObject_SIZE(Py_TYPE(co));
+    _PyCodeObjectExtra *co_extra = (_PyCodeObjectExtra*) co->co_extra;
 
-    res = _PyObject_SIZE(Py_TYPE(co));
     if (co->co_cell2arg != NULL && co->co_cellvars != NULL)
         res += PyTuple_GET_SIZE(co->co_cellvars) * sizeof(Py_ssize_t);
+
+    if (co_extra != NULL)
+        res += co_extra->ce_size * sizeof(co_extra->ce_extras[0]);
+
     return PyLong_FromSsize_t(res);
 }