Refixed pr5050 per Anders comment. Test case enhanced

per Doug's comment.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@82791 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/lib/Sema/SemaExprCXX.cpp b/lib/Sema/SemaExprCXX.cpp
index 76c64f492b157e28f9e4a01c10e551110e765c53..112797085859eabef0ac6c803eac9cb06ea12f50 100644 (file)
--- a/lib/Sema/SemaExprCXX.cpp
+++ b/lib/Sema/SemaExprCXX.cpp
@@ -1113,9 +1113,22 @@ Sema::PerformImplicitConversion(Expr *&From, QualType ToType,
   if (SCS.CopyConstructor) {
     // FIXME: When can ToType be a reference type?
     assert(!ToType->isReferenceType());
-    if (SCS.Second == ICK_Derived_To_Base)
-      ImpCastExprToType(From, ToType, CastExpr::CK_DerivedToBase,
-                        /*isLvalue=*/true);
+    if (SCS.Second == ICK_Derived_To_Base) {
+      ASTOwningVector<&ActionBase::DeleteExpr> ConstructorArgs(*this);
+      if (CompleteConstructorCall(cast<CXXConstructorDecl>(SCS.CopyConstructor),
+                                  MultiExprArg(*this, (void **)&From, 1),
+                                  /*FIXME:ConstructLoc*/SourceLocation(), 
+                                  ConstructorArgs))
+        return true;
+      OwningExprResult FromResult =
+        BuildCXXConstructExpr(/*FIXME:ConstructLoc*/SourceLocation(),
+                              ToType, SCS.CopyConstructor,
+                              move_arg(ConstructorArgs));
+      if (FromResult.isInvalid())
+        return true;
+      From = FromResult.takeAs<Expr>();
+      return false;
+    }
     OwningExprResult FromResult =
       BuildCXXConstructExpr(/*FIXME:ConstructLoc*/SourceLocation(),
                             ToType, SCS.CopyConstructor,

diff --git a/test/CodeGenCXX/PR5050-constructor-conversion.cpp b/test/CodeGenCXX/PR5050-constructor-conversion.cpp
index adfe74ffbc341d6ccfd83f992fe99b87930d1c74..7c7068742d5ccf01480168494e91c7aa34987039 100644 (file)
--- a/test/CodeGenCXX/PR5050-constructor-conversion.cpp
+++ b/test/CodeGenCXX/PR5050-constructor-conversion.cpp
@@ -4,7 +4,7 @@
 // RUN: FileCheck -check-prefix LP32 --input-file=%t-32.s %s &&
 // RUN: true
 
-struct A { A(const A&); };
+struct A { A(const A&, int i1 = 1); };
 
 struct B : A { };
 
@@ -12,8 +12,8 @@ A f(const B &b) {
   return b;
 }
 
-// CHECK-LP64: call     __ZN1AC1ERK1A
+// CHECK-LP64: call     __ZN1AC1ERK1Ai
 
-// CHECK-LP32: call     L__ZN1AC1ERK1A
+// CHECK-LP32: call     L__ZN1AC1ERK1Ai