After a crash, don't restart workers with BGW_NEVER_RESTART.

Amit Khandekar

diff --git a/src/backend/postmaster/bgworker.c b/src/backend/postmaster/bgworker.c
index cf7524f4921ef372b0370ddb3d5d811f3e761635..99f4b65ea658bda7935da7633cc24128dcecc47c 100644 (file)
--- a/src/backend/postmaster/bgworker.c
+++ b/src/backend/postmaster/bgworker.c
@@ -419,9 +419,9 @@ BackgroundWorkerStopNotifications(pid_t pid)
 /*
  * Reset background worker crash state.
  *
- * We assume that, after a crash-and-restart cycle, background workers should
- * be restarted immediately, instead of waiting for bgw_restart_time to
- * elapse.
+ * We assume that, after a crash-and-restart cycle, background workers without
+ * the never-restart flag should be restarted immediately, instead of waiting
+ * for bgw_restart_time to elapse.
  */
 void
 ResetBackgroundWorkerCrashTimes(void)
@@ -433,7 +433,14 @@ ResetBackgroundWorkerCrashTimes(void)
                RegisteredBgWorker *rw;
 
                rw = slist_container(RegisteredBgWorker, rw_lnode, iter.cur);
-               rw->rw_crashed_at = 0;
+
+               /*
+                * For workers that should not be restarted, we don't want to lose
+                * the information that they have crashed; otherwise, they would be
+                * restarted, which is wrong.
+                */
+               if (rw->rw_worker.bgw_restart_time != BGW_NEVER_RESTART)
+                       rw->rw_crashed_at = 0;
        }
 }