Remove wrong CloseHandle() call.

In accordance with its own documentation, invoke CloseHandle() only when
directed in the documentation for the function that furnished the
handle.  GetModuleHandle() does not so direct.  We have been issuing
this call only in the rare event that a CRT DLL contains no "_putenv"
symbol, so lack of bug reports is uninformative.  Back-patch to 9.2 (all
supported versions).

Christian Ullrich, reviewed by Michael Paquier.

diff --git a/src/port/win32env.c b/src/port/win32env.c
index 621ec8d67f2e7e84152182f9181c60f7577ef393..188215876bb7b51378b600ea23d821095d33dc9a 100644 (file)
--- a/src/port/win32env.c
+++ b/src/port/win32env.c
@@ -92,7 +92,6 @@ pgwin32_putenv(const char *envval)
                                        rtmodules[i].putenvFunc = (PUTENVPROC) GetProcAddress(rtmodules[i].hmodule, "_putenv");
                                        if (rtmodules[i].putenvFunc == NULL)
                                        {
-                                               CloseHandle(rtmodules[i].hmodule);
                                                rtmodules[i].hmodule = INVALID_HANDLE_VALUE;
                                                continue;
                                        }