At least one of the buildbots was complaining about newview being used

without being initialized.  Also make the code conform to the comment and
return the new object.  This code needs a test!

diff --git a/Objects/memoryobject.c b/Objects/memoryobject.c
index d06d7e505f5ce404dd6e1f100ae6c18a76728173..754cbc1fbd67102c3069f99dc57f5706e05e57b1 100644 (file)
--- a/Objects/memoryobject.c
+++ b/Objects/memoryobject.c
@@ -513,12 +513,11 @@ memory_subscript(PyMemoryViewObject *self, PyObject *key)
                else {
                        /* Return a new memory-view object */
                        Py_buffer newview;
-                       PyMemoryView_FromMemory(&newview);
+                       memset(&newview, 0, sizeof(newview));
+                       return PyMemoryView_FromMemory(&newview);
                }
        }
 
-
-
         Py_INCREF(Py_NotImplemented);
         return Py_NotImplemented;
 }