]> granicus.if.org Git - php/commitdiff
Hack around global leak for now
authorNikita Popov <nikic@php.net>
Fri, 4 Jul 2014 21:15:31 +0000 (23:15 +0200)
committerNikita Popov <nikic@php.net>
Fri, 4 Jul 2014 21:15:31 +0000 (23:15 +0200)
Zend/zend_compile.c

index 239e8f006a0df17147233c49db12b5f9d18578d4..925527e814b99f0c5fe24c889ed388ab4d65939b 100644 (file)
@@ -6914,11 +6914,9 @@ void zend_compile_global_var(zend_ast *ast TSRMLS_DC) {
        }
 
        opline = emit_op(&result, ZEND_FETCH_W, &var_node, NULL TSRMLS_CC);
-       opline->extended_value = ZEND_FETCH_GLOBAL_LOCK;
 
-       if (var_node.op_type == IS_CONST) {
-               //zval_copy_ctor(&var_node.u.constant);
-       }
+       // TODO.AST Avoid double fetch
+       //opline->extended_value = ZEND_FETCH_GLOBAL_LOCK;
 
        zend_ast *fetch_ast = zend_ast_create_unary(ZEND_AST_VAR, var_ast);
        zend_compile_assign_ref_common(NULL, fetch_ast, &result TSRMLS_CC);