]> granicus.if.org Git - curl/commitdiff
Revert "multi_done: wait for name resolve to finish if still ongoing"
authorDaniel Stenberg <daniel@haxx.se>
Sat, 7 Oct 2017 22:50:33 +0000 (00:50 +0200)
committerDaniel Stenberg <daniel@haxx.se>
Sat, 7 Oct 2017 22:55:10 +0000 (00:55 +0200)
This reverts commit f3e03f6c0ac52a1bf396e03f7d7e9b5b3b7165fe.

Caused memory leaks in the fuzzer, needs to be done differently.

Disable test 1553 for now too, as it causes memory leaks without this
commit!

lib/multi.c
tests/data/DISABLED

index c87515969643597ecd8b39e13242e34380058a45..caceaf58911a556179fe4538c1bdba5239aac8cc 100644 (file)
@@ -537,12 +537,6 @@ static CURLcode multi_done(struct connectdata **connp,
     /* Stop if multi_done() has already been called */
     return CURLE_OK;
 
-  if(data->mstate == CURLM_STATE_WAITRESOLVE) {
-    /* done while still waiting for the resolve to complete */
-    struct Curl_dns_entry *throw_away;
-    (void)Curl_resolver_wait_resolv(conn, &throw_away);
-  }
-
   Curl_getoff_all_pipelines(data, conn);
 
   /* Cleanup possible redirect junk */
index 11d54b4637777f411c2d771d7edc100c0b77b140..fcbf0ffc4d47ce9415429873a10e0809d2c6655b 100644 (file)
@@ -18,3 +18,5 @@
 1510
 # Pipelining test that is causing false positives a little too often
 1903
+# causes memory leaks for now:
+1553