gcc braindamage: -Wformat-security is not turned on by -Wall -Wextra -Wformat

diff --git a/configure.ac b/configure.ac
index 552e3f5998d443adf4935006414f0851ae5bb43f..65b15da9584295d609dc1c8a6278a2c8c5fa5f3c 100644 (file)
--- a/configure.ac
+++ b/configure.ac
@@ -89,6 +89,7 @@ if test x"$GCC" = xyes; then
   flags="$flags -Wmissing-prototypes -Wpointer-arith -Wendif-labels"
   flags="$flags -Wdeclaration-after-statement -Wold-style-definition"
   flags="$flags -Wstrict-prototypes -Wundef -Wformat -Wnonnull -Wstrict-overflow"
+  flags="$flags -Wformat-security -Wformat-nonliteral -Wformat-extra-args -Wformat-contains-nul"
   for f in $flags; do
     CFLAGS="$good_CFLAGS $warnings $f"
     AC_COMPILE_IFELSE([void foo(void){}], [warnings="$warnings $f"])

diff --git a/src/main.c b/src/main.c
index bbfdb7b6b4d8ed840b9c548ae8a22279eb771291..3d4db18fd02dad052bfb0b177051d9cfb197ebea 100644 (file)
--- a/src/main.c
+++ b/src/main.c
@@ -31,7 +31,7 @@ static bool set_auth(ConfElem *elem, const char *val, PgSocket *console);
 static const char *get_auth(ConfElem *elem);
 static bool set_defer_accept(ConfElem *elem, const char *val, PgSocket *console);
 
-static const char *usage_str =
+static const char usage_str[] =
 "Usage: %s [OPTION]... config.ini\n"
 "  -d            Run in background (as a daemon)\n"
 "  -R            Do a online restart\n"