]> granicus.if.org Git - graphviz/commitdiff
remove CreateHyperlink
authorMatthew Fernandez <matthew.fernandez@gmail.com>
Tue, 13 Apr 2021 02:19:30 +0000 (19:19 -0700)
committerMatthew Fernandez <matthew.fernandez@gmail.com>
Mon, 19 Apr 2021 03:53:34 +0000 (20:53 -0700)
This function was adding no value over just calling the Hyperlink constructor
directly.

plugin/visio/VisioRender.cpp
plugin/visio/VisioText.cpp
plugin/visio/VisioText.h

index d21fef96f106440054de3226d55266ffc5ac8752..453e751c1856b93430fc5d4d37d77e552ba1f3f6 100644 (file)
@@ -216,9 +216,9 @@ namespace Visio
                AddText(job, Text::CreateText(job, p, span));
        }
 
-       void Render::AddAnchor(GVJ_t *job, char *url, char *tooltip, char *target, char *id)
+       void Render::AddAnchor(GVJ_t *job, char *url, char *tooltip, char *target, char*)
        {
-               AddHyperlink(job, Hyperlink::CreateHyperlink(job, url, tooltip, target, id));
+               AddHyperlink(job, Hyperlink(url, tooltip, target));
        }
        
        void Render::ClearGraphicsAndTexts()
index e53d87588f624807aaf22d7c26e7b4ee7192570e..f092ebd1ef173d25b4d9a36da607d7cdea5c2e8a 100644 (file)
@@ -134,11 +134,6 @@ namespace Visio
                _run.Print(job, index);
        }
 
-       Hyperlink Hyperlink::CreateHyperlink(GVJ_t*, char* url, char* tooltip, char* target, char*)
-       {
-               return Hyperlink(tooltip, url, target);
-       }
-
        Hyperlink::Hyperlink(const char* description, const char* address,
                const char* frame):
                _description(description),
index 12b38edec897df9464b83a87859ae54f19c884a7..79de2d1939b76524603195ee14151b965dc70b95 100644 (file)
@@ -97,8 +97,6 @@ namespace Visio
        class Hyperlink
        {
        public:
-               static Hyperlink CreateHyperlink(GVJ_t* job, char* url, char* tooltip, char* target, char* id);
-               
                Hyperlink(const char* description, const char* address, const char* frame);
                
                /* given the id, whether it is default, output the hyperlink */