"sureware" should not be "hwcrhk".

Also, the "to" variable used in cleanup is never non-NULL and is entirely
unused. As such, the cleanup might have been missed under genuine error
conditions and caused leaks and/or returned invalid pointers.

diff --git a/crypto/engine/hw_sureware.c b/crypto/engine/hw_sureware.c
index c4dc524e345e475abf2ead6696c87c343d5f274b..e9edbd20e315e656fffc1fd93ac6f5079cbfa34a 100644 (file)
--- a/crypto/engine/hw_sureware.c
+++ b/crypto/engine/hw_sureware.c
@@ -307,7 +307,7 @@ static int surewarehk_ctrl(int cmd, long i, void *p, void (*f)())
                        if (CRYPTO_add(&bio->references,1,CRYPTO_LOCK_BIO) > 1)
                                logstream = bio;
                        else
-                               ENGINEerr(ENGINE_F_HWCRHK_CTRL,ENGINE_R_BIO_WAS_FREED);
+                               ENGINEerr(ENGINE_F_SUREWAREHK_CTRL,ENGINE_R_BIO_WAS_FREED);
                }
                CRYPTO_w_unlock(CRYPTO_LOCK_ENGINE);
                break;
@@ -835,7 +835,6 @@ static      DSA_SIG * surewarehk_dsa_do_sign(const unsigned char *from, int flen, DSA
 {
        int ret=0;
        char *hptr=NULL;
-       unsigned char *to=NULL;
        DSA_SIG *psign=NULL;
        char msg[64]="ENGINE_dsa_do_sign";
        if (!p_surewarehk_Dsa_Sign)
@@ -870,7 +869,7 @@ static      DSA_SIG * surewarehk_dsa_do_sign(const unsigned char *from, int flen, DSA
        bn_fix_top(psign->s);
 
 err:   
-       if (to)
+       if (psign)
        {
                DSA_SIG_free(psign);
                psign=NULL;