DIFlags: use StringRef instead of raw pointer (NFC)

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@283012 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/include/llvm/IR/DebugInfoMetadata.h b/include/llvm/IR/DebugInfoMetadata.h
index 84763f48dfc1187bd2b827deb4bd926f145cca02..9b61da3387f57758d2bdcf2e2899e170dbec70d8 100644 (file)
--- a/include/llvm/IR/DebugInfoMetadata.h
+++ b/include/llvm/IR/DebugInfoMetadata.h
@@ -183,7 +183,7 @@ public:
   };
 
   static DIFlags getFlag(StringRef Flag);
-  static const char *getFlagString(DIFlags Flag);
+  static StringRef getFlagString(DIFlags Flag);
 
   /// \brief Split up a flags bitfield.
   ///

diff --git a/lib/IR/AsmWriter.cpp b/lib/IR/AsmWriter.cpp
index 0734a3772e32310b928b32ffb1a309679df022dc..fa67425bc6ce14623625b78d4bc45bb6ce911588 100644 (file)
--- a/lib/IR/AsmWriter.cpp
+++ b/lib/IR/AsmWriter.cpp
@@ -1488,8 +1488,8 @@ void MDFieldPrinter::printDIFlags(StringRef Name, DINode::DIFlags Flags) {
 
   FieldSeparator FlagsFS(" | ");
   for (auto F : SplitFlags) {
-    const char *StringF = DINode::getFlagString(F);
-    assert(StringF && "Expected valid flag");
+    auto StringF = DINode::getFlagString(F);
+    assert(!StringF.empty() && "Expected valid flag");
     Out << FlagsFS << StringF;
   }
   if (Extra || SplitFlags.empty())

diff --git a/lib/IR/DebugInfoMetadata.cpp b/lib/IR/DebugInfoMetadata.cpp
index 74f8ce84db09eb0b1aedabf45165af37ee85e0c4..96f28dd19c562f457683af91d7efb2f8b7d180c2 100644 (file)
--- a/lib/IR/DebugInfoMetadata.cpp
+++ b/lib/IR/DebugInfoMetadata.cpp
@@ -72,7 +72,7 @@ DINode::DIFlags DINode::getFlag(StringRef Flag) {
       .Default(DINode::FlagZero);
 }
 
-const char *DINode::getFlagString(DIFlags Flag) {
+StringRef DINode::getFlagString(DIFlags Flag) {
   switch (Flag) {
 #define HANDLE_DI_FLAG(ID, NAME)                                               \
   case Flag##NAME:                                                             \