Refactor AC_INIT in configure.ac and PHP versions

Since Autoconf 2.53 the AC_INIT call with only a single argument has
been made obsolete and now includes several other optional arguments to
make installation experience a bit better by providing program version
and links to the project in the `./configure -h` output. This patch also
updates win build version. The phpize.m4 AC_INIT has been updated with
the call without arguments.

diff --git a/buildconf b/buildconf
index 3248cd612d105b04d9f20a89d32346e409a4952e..ad9febfef50f272c5fc9aaa0e4afebfb4575d1f9 100755 (executable)
--- a/buildconf
+++ b/buildconf
@@ -9,9 +9,9 @@ debug=0
 # Go to project root.
 cd $(CDPATH= cd -- "$(dirname -- "$0")" && pwd -P)
 
-eval $(grep '^PHP_EXTRA_VERSION=' configure.ac)
-case "$PHP_EXTRA_VERSION" in
-  *-dev)
+php_extra_version=$(grep '^AC_INIT(' configure.ac)
+case "$php_extra_version" in
+  *-dev*)
     dev=1
     ;;
   *)

diff --git a/configure.ac b/configure.ac
index 3e515181951eca168e79d098a6db6bbcacee0c1d..6cce23636441aeb835d4ea149fa515597b3fcece 100644 (file)
--- a/configure.ac
+++ b/configure.ac
@@ -8,7 +8,8 @@ dnl Basic autoconf initialization, generation of config.nice.
 dnl -------------------------------------------------------------------------
 
 AC_PREREQ([2.68])
-AC_INIT([main/php_version.h])
+AC_INIT([PHP],[7.4.0-dev],[https://bugs.php.net],[php],[https://www.php.net])
+AC_CONFIG_SRCDIR([main/php_version.h])
 AC_CONFIG_AUX_DIR([build])
 AC_PRESERVE_HELP_ORDER
 
@@ -99,10 +100,13 @@ extern "C++" {
 #endif /* PHP_CONFIG_H */
 ])
 
-PHP_MAJOR_VERSION=7
-PHP_MINOR_VERSION=4
-PHP_RELEASE_VERSION=0
-PHP_EXTRA_VERSION="-dev"
+ac_IFS=$IFS; IFS="."
+set $(echo AC_PACKAGE_VERSION | $SED 's/\([[0-9\.]]*\)\(.*\)/\1\.\2/')
+IFS=$ac_IFS
+PHP_MAJOR_VERSION=[$]1
+PHP_MINOR_VERSION=[$]2
+PHP_RELEASE_VERSION=[$]3
+PHP_EXTRA_VERSION=[$]4
 PHP_VERSION="$PHP_MAJOR_VERSION.$PHP_MINOR_VERSION.$PHP_RELEASE_VERSION$PHP_EXTRA_VERSION"
 PHP_VERSION_ID=`expr [$]PHP_MAJOR_VERSION \* 10000 + [$]PHP_MINOR_VERSION \* 100 + [$]PHP_RELEASE_VERSION`
 

diff --git a/scripts/phpize.m4 b/scripts/phpize.m4
index 9b89d1b9cd602f832ce4efdf21c6b496e7436aca..d3b471b5cd3abef0d59e0411f9da47e1b1964182 100644 (file)
--- a/scripts/phpize.m4
+++ b/scripts/phpize.m4
@@ -1,7 +1,8 @@
 dnl This file becomes configure.ac for self-contained extensions.
 
 AC_PREREQ([2.68])
-AC_INIT(config.m4)
+AC_INIT
+AC_CONFIG_SRCDIR([config.m4])
 AC_CONFIG_AUX_DIR([build])
 AC_PRESERVE_HELP_ORDER
 

diff --git a/win32/build/confutils.js b/win32/build/confutils.js
index f43572c9dd9f646386c2ac422c37162d9b54cdbb..19a2504fa9c327b90a918501d86fb8a3f3d179ed 100644 (file)
--- a/win32/build/confutils.js
+++ b/win32/build/confutils.js
@@ -105,24 +105,17 @@ var PHP_VERSION_STRING = "7.3.0";
 function get_version_numbers()
 {
        var cin = file_get_contents("configure.ac");
+       var regex = /AC_INIT.+(\d+)\.(\d+)\.(\d+)([^\,^\]]*).+/g;
 
-       if (cin.match(new RegExp("PHP_MAJOR_VERSION=(\\d+)"))) {
+       if (cin.match(new RegExp(regex))) {
                PHP_VERSION = RegExp.$1;
+               PHP_MINOR_VERSION = RegExp.$2;
+               PHP_RELEASE_VERSION = RegExp.$3;
+               PHP_EXTRA_VERSION = RegExp.$4;
        }
-       if (cin.match(new RegExp("PHP_MINOR_VERSION=(\\d+)"))) {
-               PHP_MINOR_VERSION = RegExp.$1;
-       }
-       if (cin.match(new RegExp("PHP_RELEASE_VERSION=(\\d+)"))) {
-               PHP_RELEASE_VERSION = RegExp.$1;
-       }
-       PHP_VERSION_STRING = PHP_VERSION + "." + PHP_MINOR_VERSION + "." + PHP_RELEASE_VERSION;
 
-       if (cin.match(new RegExp("PHP_EXTRA_VERSION=\"([^\"]+)\""))) {
-               PHP_EXTRA_VERSION = RegExp.$1;
-               if (PHP_EXTRA_VERSION.length) {
-                       PHP_VERSION_STRING += PHP_EXTRA_VERSION;
-               }
-       }
+       PHP_VERSION_STRING = PHP_VERSION + "." + PHP_MINOR_VERSION + "." + PHP_RELEASE_VERSION + PHP_EXTRA_VERSION;
+
        DEFINE('PHP_VERSION_STRING', PHP_VERSION_STRING);
 }